Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/just workload in workload graph #135

Merged
merged 4 commits into from
Sep 8, 2024

Conversation

L-M-Sherlock
Copy link
Member

@L-M-Sherlock L-M-Sherlock added the bug Something isn't working label Sep 8, 2024
@Expertium
Copy link
Contributor

You can use this for smoothing:

from scipy.signal import savgol_filter
cost_per_memorization = savgol_filter(cost_per_memorization_raw, 10, 2)

10 is the number of datapoints in a rolling window used for smoothing, 2 is the degree of a polynomial that is used to fit the data. But this requires a lot of fine-tuning, and doesn't make the graph perfectly smooth.

@L-M-Sherlock
Copy link
Member Author

What about changing the thresholds of different color areas?

@Expertium
Copy link
Contributor

Expertium commented Sep 8, 2024

    target2 = 2 * min_w
    target3 = 3 * min_w

Change these to these:

target2 = 1.5 * min_w
target3 = 2 * min_w

EDIT: ok, there's more. I'll submit a PR later. Finish this PR first.

@L-M-Sherlock L-M-Sherlock added this pull request to the merge queue Sep 8, 2024
Merged via the queue into main with commit c7568ae Sep 8, 2024
2 checks passed
@L-M-Sherlock L-M-Sherlock deleted the Fix/just-workload-in-workload-graph branch September 8, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants