Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: derive Hash for FSRSReview and FSRSItem #253

Closed
wants to merge 1 commit into from

Conversation

sineptic
Copy link
Contributor

No description provided.

@L-M-Sherlock
Copy link
Member

Thank you for your contribution! Could you please provide more details on why you decided to derive the Hash trait for FSRSReview and FSRSItem? Understanding the motivation behind this change will help us in the review process.

@sineptic
Copy link
Contributor Author

Excuse me please. I feeling so guilty, I don't think before trying to contribute.

My task manager type has tasks_to_complete and tasks_pool. I wrote function find_tasks_to_recall, that (I think) find tasks to recall in fastest way, but only approach for this is implement Cmp(compare time to recall) for tasks wrapper(to use in BTreeSet and stop when first not to complete found). I quickly realize, that comparing time with default parameters not work for me, so BTreeSet -> HashSet and scan all for tasks to complete, but I don't think that Vec could replace HashSet

@sineptic sineptic closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants