-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test into ci #31
add test into ci #31
Conversation
linux and macos have different floating point implementation. So instead of |
it seems that linux cache is empty
|
Currently, the CI configuration seems a bit redundant, we can only run And it may be best to use https://github.com/marketplace/actions/rustup-toolchain-install to ensure all tool versions are aligned and up to date. |
#33 should fix the caching issue. Agreed that pinning Rust is a good idea, but rust-toolchain.toml is a better choice than a GitHub action, as it also works when people test locally. |
Regarding tests on multiple platforms, and building in release mode:
|
I've pushed some changes into #32 that uses the file to run the tests, but skips the training test, so things are still nice and fast when the cache is fresh. If you guys approve of those changes, maybe this PR could be adjusted to focus on separate workflows for running the tests on Mac/Windows, and maybe a separate one for running the training too. |
I am ok with that :) ,feel free to modify this PR. |
Linux 34s, Mac 1m, Windows 3:30. 😅 |
This may has some problems about floating point number. Let's try it.