Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ob_revlog.csv没有记录卡片review_state为0的情况 #21

Closed
dryezl opened this issue Oct 31, 2023 · 6 comments
Closed

ob_revlog.csv没有记录卡片review_state为0的情况 #21

dryezl opened this issue Oct 31, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@dryezl
Copy link

dryezl commented Oct 31, 2023

Describe the bug
我用fsrs-optimizer优化复习数据(ob_revlog.csv)时,程序报错。部分报错信息如下

Ratio of `again`, `hard`, `good` and `easy` ratings for new cards: 0.00, 0.00, 0.00, 0.00
probabilities do not sum to 1
Failed to process /content/ob_revlog.csv

重新设置空白vault,下载obsidian-spaced-repetition-recall

卡牌复习之后,ob_revlog.csv没有review_state为0的记录

如果没有这个记录的话,意味着这个卡片不能成为优化的有效卡片。

          每张卡片的复习数据的第一条的review_state是否为0

Originally posted by @L-M-Sherlock in open-spaced-repetition/fsrs-optimizer#13 (comment)

@dryezl dryezl added the bug Something isn't working label Oct 31, 2023
@L-M-Sherlock
Copy link
Member

你的数据发我一份,我看看这个bug是不是optimizer那边也有问题。

@dryezl
Copy link
Author

dryezl commented Oct 31, 2023

这是优化时使用的数据,ob_revlog.csv 和使用的代码

@Newdea
Copy link
Collaborator

Newdea commented Oct 31, 2023

你的数据发我一份,我看看这个bug是不是optimizer那边也有问题。

应该是插件的问题,数据记录,新增卡片时没有记录到表格中。只在复习时才有,而第一次复习,卡片状态就会从新卡片(0)变成学习中(1)。

新卡片的时间用处应该不大,只有在开始重复时才有意义。
optimizer中能不能从判断0改为判断0或1,插件这边新增时就记录的话可能会有重复混乱不太好判断状态,目前只是在复习反馈时才记录。

@Newdea
Copy link
Collaborator

Newdea commented Nov 15, 2023

代码中是用的复习后的review_state,下版更新会改用复习前的review_state(即直接采用ReviewLog内的数据),就可以解决这个问题了

//Get the review log after rating `Good`:
review_log = scheduling_cards[rating.Good].review_log

@dryezl
Copy link
Author

dryezl commented Nov 24, 2023

请问这个下一版是哪个软件呢?obsidian-spaced-repetition-recall还是fsrs-optimizer呢?

@L-M-Sherlock
Copy link
Member

前者。

Newdea added a commit that referenced this issue Dec 1, 2023
    Merge branch 'release/log'
    Merge branch 'upstream/master'
    Merge branch 'Feat/refactor'
    * create Object
    * use stats
    * keep itemId
    * getInstance

    updateStats
    isNew and isDue
    trackFile card
    refactor
    LocationSwitch
    hide debug commands
    change save name
    close #26: Interval时间的展示
    close [FEAT] Interval时间的展示 #26
    * add info
    * fix merge errors
    * update readme
    dummyDueDateForNewCard
    trackedNoteToDecks
    add test
    fix data load
    fix convert
    add info
    verifyItems
    fix revlog
    fix stats
    fix #21 review_state为0的情况
    del debug msg
    openfileButton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants