-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new column #168
Added a new column #168
Conversation
I added a column with input features. Ngl, I feel like my idea of using abbreviations isn't that great. But typing all that out would make the table huge, and adding more columns isn't great either, so I guess using a ton of abbreviations is the lesser evil.
I think RMSE bins exploit can be considered "IL+G" |
Do you think this column should be moved to the left, between "Log Loss" and "Parameters"? |
I think it's fine as it is. |
Please add them to here as well: Lines 90 to 128 in 0cad528
|
@L-M-Sherlock this PR is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I added a column with input features. Ngl, I feel like my idea of using abbreviations isn't that great. But typing all that out would make the table huge, and adding more columns isn't great either, so I guess using a ton of abbreviations is the lesser evil.
@1DWalker idk about the RMSE bins exploit thingy, do we need to specify some input features? I mean, it uses interval lengths and grades...I think?