Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/reschedule #127

Merged
merged 24 commits into from
Oct 11, 2024
Merged

Refactor/reschedule #127

merged 24 commits into from
Oct 11, 2024

Conversation

ishiko732
Copy link
Collaborator

@ishiko732 ishiko732 commented Sep 22, 2024

Related issues:

close : #125

The reschedule method will consider the following scenarios:

  1. Allow rescheduling from the beginning/first_card.
  2. Reschedule based on reviews.
  3. Provide a reschedule_item when the due time of the reschedule card differs from the current_card.
  4. Allow skipping manual revlog and opt not to update fsrs_memory_state.
  5. Use now to determine the time of rescheduling.
  6. Ensure correct rescheduling even when due or forget is manually specified.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5de8318) to head (594d658).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #127   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        12    +1     
  Lines          609       650   +41     
  Branches        64        70    +6     
=========================================
+ Hits           609       650   +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishiko732 ishiko732 changed the title [TODO]Refactor/reschedule Refactor/reschedule Oct 6, 2024
@ishiko732 ishiko732 marked this pull request as ready for review October 6, 2024 09:43
@ishiko732 ishiko732 requested a review from L-M-Sherlock October 8, 2024 15:48
@ishiko732
Copy link
Collaborator Author

This refactor only modifies the reschedule method, thus only the minor version will be updated.

Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishiko732 ishiko732 merged commit 34e59a4 into main Oct 11, 2024
5 checks passed
@ishiko732 ishiko732 deleted the Refactor/reschedule branch October 11, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] What's the usage of reschedule?
2 participants