Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/update FSRS-4.5 params into FSRS-5 properly #132

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Fix/update FSRS-4.5 params into FSRS-5 properly #132

merged 2 commits into from
Oct 21, 2024

Conversation

ishiko732
Copy link
Collaborator

@ishiko732 ishiko732 added the bug Something isn't working label Oct 21, 2024
@ishiko732 ishiko732 changed the title Fix/update FSRS-4.5 params into FSRS-5 Fix/update FSRS-4.5 params into FSRS-5 properly Oct 21, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (aaa1543) to head (638e3c0).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #132   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          650       652    +2     
  Branches        70        70           
=========================================
+ Hits           650       652    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

L-M-Sherlock
L-M-Sherlock approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishiko732 ishiko732 merged commit 2adce32 into main Oct 21, 2024
5 checks passed
@ishiko732 ishiko732 deleted the Fix/update-FSRS-4.5-params-into-FSRS-5 branch October 21, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-M-Sherlock L-M-Sherlock L-M-Sherlock approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishiko732 @L-M-Sherlock