Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pylint work with python 3.11 and fix new errors #125

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

lmolkova
Copy link
Contributor

Build scripts now use Python 3.11, but old pylint does not work with it:

https://github.com/open-telemetry/build-tools/actions/runs/3439733856/jobs/5737365717

This change updates pylint and also fixes new errors from it.

@lmolkova lmolkova requested a review from a team November 10, 2022 21:57
@lmolkova lmolkova requested a review from Oberon00 as a code owner November 10, 2022 21:57
semantic-conventions/.pylintrc Show resolved Hide resolved
@lmolkova
Copy link
Contributor Author

@open-telemetry/specs-approvers can someone please take a look and merge if you're happy with it?

@Oberon00 Oberon00 added bug Something isn't working semconv Related to the semantic convention generator. labels Nov 18, 2022
@Oberon00
Copy link
Member

@open-telemetry/technical-committee I think only you can merge PRs here?

@arminru
Copy link
Member

arminru commented Nov 30, 2022

@lmolkova Thank you for the fix!
@Oberon00 Thank you for pinging us 🙂

@arminru arminru merged commit ec90d81 into open-telemetry:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semconv Related to the semantic convention generator.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants