Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple semconv in --only flag #157

Merged
merged 8 commits into from
Mar 15, 2023
Merged

Allow multiple semconv in --only flag #157

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
43e722b
allowing multiple only flags to generate multiple conventions
lmolkova Mar 10, 2023
adfb656
oops
lmolkova Mar 10, 2023
ebee924
review comments
lmolkova Mar 10, 2023
f5a8ef3
lint
lmolkova Mar 10, 2023
78971f2
lint
lmolkova Mar 10, 2023
a16a798
validate --only
lmolkova Mar 13, 2023
d61d83b
lint
lmolkova Mar 13, 2023
0d380ca
Merge branch 'main' into alt-fix-codegen-119
lmolkova Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions semantic-conventions/src/opentelemetry/semconv/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,12 @@ def exclude_file_list(folder: str, pattern: str) -> List[str]:
return file_names


def filter_semconv(semconv, type_filter):
if type_filter:
def filter_semconv(semconv, types_filter):
if types_filter:
semconv.models = {
id: model
for id, model in semconv.models.items()
if model.GROUP_TYPE_NAME == type_filter
if model.GROUP_TYPE_NAME in types_filter
}


Expand Down Expand Up @@ -211,7 +211,9 @@ def setup_parser():
parser.add_argument(
"--only",
choices=list(CONVENTION_CLS_BY_GROUP_TYPE.keys()),
help="Process only semantic conventions of the specified type.",
type=str,
nargs="+",
lmolkova marked this conversation as resolved.
Show resolved Hide resolved
help="Process only semantic conventions of the specified types.",
)
parser.add_argument(
"--yaml-root",
Expand Down