Update nsxtreceiver to checkapi standards (#26509)

stop exporting `NewMockClient` method to align with checkapi standards as related to issue #26304 **Link to tracking Issue:** #26304
open-telemetry · Sep 12, 2023 · 61422ad · 61422ad
1 parent b550253
commit 61422ad
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/cmd/checkapi/allowlist.txt b/cmd/checkapi/allowlist.txt
@@ -29,7 +29,6 @@ receiver/kafkareceiver
 receiver/mongodbatlasreceiver
 receiver/mongodbreceiver
 receiver/mysqlreceiver
-receiver/nsxtreceiver
 receiver/podmanreceiver
 receiver/pulsarreceiver
 receiver/windowseventlogreceiver
diff --git a/receiver/nsxtreceiver/client_mock_test.go b/receiver/nsxtreceiver/client_mock_test.go
@@ -132,8 +132,8 @@ func (m *MockClient) TransportNodes(ctx context.Context) ([]model.TransportNode,
 	return r0, r1
 }
 
-// NewMockClient creates a new instance of MockClient. It also registers the testing.TB interface on the mock and a cleanup function to assert the mocks expectations.
-func NewMockClient(t testing.TB) *MockClient {
+// newMockClient creates a new instance of MockClient. It also registers the testing.TB interface on the mock and a cleanup function to assert the mocks expectations.
+func newMockClient(t testing.TB) *MockClient {
 	mock := &MockClient{}
 	mock.Mock.Test(t)
 

diff --git a/receiver/nsxtreceiver/scraper_test.go b/receiver/nsxtreceiver/scraper_test.go
@@ -25,7 +25,7 @@ import (
 )
 
 func TestScrape(t *testing.T) {
-	mockClient := NewMockClient(t)
+	mockClient := newMockClient(t)
 
 	mockClient.On("ClusterNodes", mock.Anything).Return(loadTestClusterNodes())
 	mockClient.On("TransportNodes", mock.Anything).Return(loadTestTransportNodes())
@@ -68,7 +68,7 @@ func TestScrape(t *testing.T) {
 }
 
 func TestScrapeTransportNodeErrors(t *testing.T) {
-	mockClient := NewMockClient(t)
+	mockClient := newMockClient(t)
 	mockClient.On("TransportNodes", mock.Anything).Return(nil, errUnauthorized)
 	scraper := newScraper(
 		&Config{
@@ -84,7 +84,7 @@ func TestScrapeTransportNodeErrors(t *testing.T) {
 }
 
 func TestScrapeClusterNodeErrors(t *testing.T) {
-	mockClient := NewMockClient(t)
+	mockClient := newMockClient(t)
 
 	mockClient.On("ClusterNodes", mock.Anything).Return(nil, errUnauthorized)
 	mockClient.On("TransportNodes", mock.Anything).Return(loadTestTransportNodes())