aws/containerinsight: convert uint types to int instead of float (#5037)

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
open-telemetry · Aug 31, 2021 · db1e2b2 · db1e2b2
1 parent 5bc5b75
commit db1e2b2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/internal/aws/containerinsight/utils.go b/internal/aws/containerinsight/utils.go
@@ -196,11 +196,11 @@ func ConvertToOTLPMetrics(fields map[string]interface{}, tags map[string]string,
 		case int64:
 			intGauge(ilms.AppendEmpty(), key, unit, t, timestamp)
 		case uint:
-			doubleGauge(ilms.AppendEmpty(), key, unit, float64(t), timestamp)
+			intGauge(ilms.AppendEmpty(), key, unit, int64(t), timestamp)
 		case uint32:
-			doubleGauge(ilms.AppendEmpty(), key, unit, float64(t), timestamp)
+			intGauge(ilms.AppendEmpty(), key, unit, int64(t), timestamp)
 		case uint64:
-			doubleGauge(ilms.AppendEmpty(), key, unit, float64(t), timestamp)
+			intGauge(ilms.AppendEmpty(), key, unit, int64(t), timestamp)
 		case float32:
 			doubleGauge(ilms.AppendEmpty(), key, unit, float64(t), timestamp)
 		case float64:

diff --git a/internal/aws/containerinsight/utils_test.go b/internal/aws/containerinsight/utils_test.go
@@ -115,6 +115,12 @@ func convertToInt64(value interface{}) int64 {
 		return int64(t)
 	case int64:
 		return t
+	case uint:
+		return int64(t)
+	case uint32:
+		return int64(t)
+	case uint64:
+		return int64(t)
 	default:
 		valueType := fmt.Sprintf("%T", value)
 		log.Printf("Detected unexpected type: %v", valueType)
@@ -124,12 +130,6 @@ func convertToInt64(value interface{}) int64 {
 
 func convertToFloat64(value interface{}) float64 {
 	switch t := value.(type) {
-	case uint:
-		return float64(t)
-	case uint32:
-		return float64(t)
-	case uint64:
-		return float64(t)
 	case float32:
 		return float64(t)
 	case float64: