Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[github-actions] Hanging "Cache Go" step #10289

Closed
djaglowski opened this issue May 24, 2022 · 7 comments
Closed

[github-actions] Hanging "Cache Go" step #10289

djaglowski opened this issue May 24, 2022 · 7 comments
Assignees
@djaglowski
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues priority:p2 Medium

Comments

@djaglowski
Copy link
Member

djaglowski commented May 24, 2022 •
edited
Loading

Some github actions jobs are failing to complete the Cache Go step. The same "downloading" message appears repeatedly.

Example here.

image
@djaglowski djaglowski added bug Something isn't working ci-cd CI, CD, testing, build issues labels May 24, 2022
@djaglowski
Copy link
Member Author

Here again: https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6581426540?check_suite_focus=true#step:4:21571

@djaglowski
Copy link
Member Author

Here again: https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6596380994?check_suite_focus=true#step:4:3787

@djaglowski
Copy link
Member Author

Here too: https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6595575905?check_suite_focus=true#step:8:6736

@dmitryax dmitryax added the priority:p2 Medium label May 27, 2022
@djaglowski
Copy link
Member Author

Issue appears to be a bug in actions/cache@v3 , tracked here.

@djaglowski
Copy link
Member Author

Leaving this issue open to capture more examples, in case they are helpful for resolving the root cause.

@djaglowski
Copy link
Member Author

Here again: https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6815079545?check_suite_focus=true#step:4:11

This was referenced Jun 20, 2022
Closed
Closed
@djaglowski
Copy link
Member Author

Closing this issue, as it has been all but confirmed to be an upstream problem. (See actions/cache#810)

The issue still occurs frequently, but will hopefully be resolved upstream.

@djaglowski djaglowski mentioned this issue Aug 5, 2022
Closed
@djaglowski djaglowski mentioned this issue Aug 22, 2022
Merged
@mx-psi mx-psi mentioned this issue May 11, 2023
Closed
lisguo pushed a commit to amazon-contributing/opentelemetry-collector-contrib that referenced this issue Jul 9, 2024
@jpkrohling @lisguo
[confighttp] Apply MaxRequestBodySize to the result of a decompressed…
890f046 
… body (open-telemetry#10289)

This change applies a restriction on the size of the decompressed
payload. Before this change, this is the result of the test added in
this PR:

```
--- FAIL: TestServerWithDecompression (0.03s)
    /home/jpkroehling/Projects/src/github.com/open-telemetry/opentelemetry-collector/config/confighttp/confighttp_test.go:1327: 
        	Error Trace:	/home/jpkroehling/Projects/src/github.com/open-telemetry/opentelemetry-collector/config/confighttp/confighttp_test.go:1327
        	            				/usr/lib/golang/src/net/http/server.go:2166
        	            				/home/jpkroehling/Projects/src/github.com/open-telemetry/opentelemetry-collector/config/confighttp/compression.go:163
        	            				/home/jpkroehling/Projects/src/github.com/open-telemetry/opentelemetry-collector/config/confighttp/confighttp.go:455
        	            				/usr/lib/golang/src/net/http/server.go:2166
        	            				/home/jpkroehling/go/pkg/mod/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.52.0/handler.go:212
        	            				/home/jpkroehling/go/pkg/mod/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.52.0/handler.go:73
        	            				/usr/lib/golang/src/net/http/server.go:2166
        	            				/home/jpkroehling/Projects/src/github.com/open-telemetry/opentelemetry-collector/config/confighttp/clientinfohandler.go:26
        	            				/usr/lib/golang/src/net/http/server.go:3137
        	            				/usr/lib/golang/src/net/http/server.go:2039
        	            				/usr/lib/golang/src/runtime/asm_amd64.s:1695
        	Error:      	An error is expected but got nil.
        	Test:       	TestServerWithDecompression
    /home/jpkroehling/Projects/src/github.com/open-telemetry/opentelemetry-collector/config/confighttp/confighttp_test.go:1328: 
        	Error Trace:	/home/jpkroehling/Projects/src/github.com/open-telemetry/opentelemetry-collector/config/confighttp/confighttp_test.go:1328
        	            				/usr/lib/golang/src/net/http/server.go:2166
        	            				/home/jpkroehling/Projects/src/github.com/open-telemetry/opentelemetry-collector/config/confighttp/compression.go:163
        	            				/home/jpkroehling/Projects/src/github.com/open-telemetry/opentelemetry-collector/config/confighttp/confighttp.go:455
        	            				/usr/lib/golang/src/net/http/server.go:2166
        	            				/home/jpkroehling/go/pkg/mod/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.52.0/handler.go:212
        	            				/home/jpkroehling/go/pkg/mod/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.52.0/handler.go:73
        	            				/usr/lib/golang/src/net/http/server.go:2166
        	            				/home/jpkroehling/Projects/src/github.com/open-telemetry/opentelemetry-collector/config/confighttp/clientinfohandler.go:26
        	            				/usr/lib/golang/src/net/http/server.go:3137
        	            				/usr/lib/golang/src/net/http/server.go:2039
        	            				/usr/lib/golang/src/runtime/asm_amd64.s:1695
        	Error:      	
        	Test:       	TestServerWithDecompression
    /home/jpkroehling/Projects/src/github.com/open-telemetry/opentelemetry-collector/config/confighttp/confighttp_test.go:1357: 
        	Error Trace:	/home/jpkroehling/Projects/src/github.com/open-telemetry/opentelemetry-collector/config/confighttp/confighttp_test.go:1357
        	Error:      	Not equal: 
        	            	expected: 200
        	            	actual  : 400
        	Test:       	TestServerWithDecompression
FAIL
FAIL	go.opentelemetry.io/collector/config/confighttp	0.036s
FAIL
```

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

---------

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djaglowski djaglowski

Labels
bug Something isn't working ci-cd CI, CD, testing, build issues priority:p2 Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djaglowski @dmitryax