Bump github.com/jaegertracing/jaeger from 1.41.0 to 1.42.0 causes issues

[codeboten]

Component(s)

extension/jaegerremotesampling

What happened?

Description

Updating the dependency from 1.41.0 to 1.42.0 causes the following error in the test because of the change in using api_v2.SamplingStrategyResponse from sampling.SamplingStrategyResponse:

--- FAIL: TestEndpointsAreWired (0.01s)
    --- FAIL: TestEndpointsAreWired/new (0.00s)
        http_test.go:86: 
                Error Trace:    /Users/alex.boten/workspace/opentelemetry-collector-contrib/extension/jaegerremotesampling/internal/http_test.go:86
                Error:          Not equal: 
                                expected: "{\"strategyType\":\"PROBABILISTIC\"}"
                                actual  : "{}"
                            
                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1 +1 @@
                                -{"strategyType":"PROBABILISTIC"}
                                +{}
                Test:           TestEndpointsAreWired/new
FAIL
FAIL    github.com/open-telemetry/opentelemetry-collector-contrib/extension/jaegerremotesampling/internal       10.753s
FAIL

The strategyType field in the api_v2 is not rendered because of the omitempty tag in the struct. What's the right way to address this in the extension?

See the PR here: #18400

Collector version

not-released-yet

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[github-actions]

Pinging code owners:

• extension/jaegerremotesampling: @jpkrohling @frzifus

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[jpkrohling]

@frzifus, I think you did something related to this recently?

[codeboten]

Thanks @jpkrohling

[frzifus]

I assume you mean #18070? Let me see.

[frzifus]

I will check the details tomorrow.

• Replace Thrift-gen with Proto-gen types for sampling strategies jaegertracing/jaeger#4181
• Invalid expectations of JSON format for Jaeger remote sampling strategies opentelemetry-specification#3126

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• extension/jaegerremotesampling: @jpkrohling @frzifus

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• extension/jaegerremotesampling: @jpkrohling @frzifus

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• extension/jaegerremotesampling: @jpkrohling @frzifus

See Adding Labels via Comments if you do not have permissions to add labels yourself.