-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/prometheus] collector do not support metric histogram with temporality = DELTA #19153
Comments
Pinging code owners for exporter/prometheus: @Aneurysm9. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
AIUI this is by design, you need to convert them to cumulative temporality and otherwise they will be dropped
I will let @Aneurysm9 describe the best way to handle this |
#9006 looks to implement that conversion logic for delta histograms. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
@mx-psi what is the latest status on this issue? |
@hampusrosvall I am not actively keeping track of this issue, it is not fixed and there does not seem to be any open PRs trying to fix it but I don't have more information. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
…#23790) **Description:** <Describe what has changed.> This continues the work done in the now closed [PR](#20530). I have addressed issues raised in the original PR by - Adding logic to handle timestamp misalignments - Adding fix + a out-of-bounds bug In addition, I have performed end-to-end testing in a local setup, and confirmed that accumulated histogram time series are correct. **Link to tracking Issue:** <Issue number if applicable> #4968 #9006 #19153 **Testing:** <Describe what testing was performed and which tests were added.> Added tests for timestamp misalignment and an out-of-bounds bug discovered in the previous PR. End-to-end testing to ensure histogram bucket counts exported to Prometheus are correct --------- Signed-off-by: Loc Mai <locmai0201@gmail.com> Signed-off-by: xchen <xchen@axon.com> Signed-off-by: stephenchen <x.chen1016@gmail.com> Co-authored-by: Lev Popov <nabam@nabam.net> Co-authored-by: Lev Popov <leo@nabam.net> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Loc Mai <locmai0201@gmail.com> Co-authored-by: Alex Boten <aboten@lightstep.com>
…open-telemetry#23790) **Description:** <Describe what has changed.> This continues the work done in the now closed [PR](open-telemetry#20530). I have addressed issues raised in the original PR by - Adding logic to handle timestamp misalignments - Adding fix + a out-of-bounds bug In addition, I have performed end-to-end testing in a local setup, and confirmed that accumulated histogram time series are correct. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#4968 open-telemetry#9006 open-telemetry#19153 **Testing:** <Describe what testing was performed and which tests were added.> Added tests for timestamp misalignment and an out-of-bounds bug discovered in the previous PR. End-to-end testing to ensure histogram bucket counts exported to Prometheus are correct --------- Signed-off-by: Loc Mai <locmai0201@gmail.com> Signed-off-by: xchen <xchen@axon.com> Signed-off-by: stephenchen <x.chen1016@gmail.com> Co-authored-by: Lev Popov <nabam@nabam.net> Co-authored-by: Lev Popov <leo@nabam.net> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Loc Mai <locmai0201@gmail.com> Co-authored-by: Alex Boten <aboten@lightstep.com>
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Describe the bug
A clear and concise description of what the bug is.
i use java-instrument to collect metric and use optl-collector to collect metric, and use prometheus to scrap metric from optl-collector and store.
when i use java-instrument agent with below config
when I
curl http://localhost:8889/metrics
it works fine. data present in metrics.
but if i change
-Dotel.exporter.otlp.metrics.temporality.preference
toDELTA
when I
curl http://localhost:8889/metrics
it has problem.
DELTA
data not present in metrics.Steps to reproduce
java client to produce metric
optl-collector's log looks well , but not show with
curl http://localhost:8889/metrics
What did you expect to see?
A clear and concise description of what you expected to see.
metric should present on
curl http://localhost:8889/metrics
when use temporality with temporality = DELTAWhat did you see instead?
A clear and concise description of what you saw instead.
metric did not present on
curl http://localhost:8889/metrics
when use temporality with temporality = DELTAWhat version did you use?
Version: (e.g.,
v0.4.0
,1eb551b
, etc)v0.72.0
What config did you use?
Config: (e.g. the yaml config file)
Environment
OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")
OS: macos
use binary no compiled
Additional context
Add any other context about the problem here.
optl-collecor log:
curl data:
The text was updated successfully, but these errors were encountered: