-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move README status table to separate machine-readable file #19175
Comments
Taking this a step further, wouldn't it make sense to have such a machine readable file for all standardized parts of the readme? For example: class: processor
type: transform
description: modifies telemetry based on configuration using the [OpenTelemetry Transformation Language](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/pkg/ottl)
stability:
traces: beta
metrics: alpha
logs: alpha
distributions: [contrib]
stateful: true # See https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/18878
warnings: # See https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/19172
- unsound_transformations
- identity_conflict
- orphaned_telemetry |
Something like this would also be very useful for open-telemetry/opentelemetry-collector#7274 |
And I'll argue that Stateful fits into Warnings and doesn't need its own section to indicate Stateless. But I'm not willing to die on that hill. |
happy to look into this if no one else already does! |
I started looking at adding this to |
I support this. |
I added a couple items to 'future work' on the original post including @djaglowski and @codeboten's suggestions. I agree with @codeboten that we can start with just the status and work from there.
@codeboten one open question for me if we re-use
@sh0rez Sure :) I think we can start with only the status table and open a PR to do this on a few components to see how things work out in practice. I suggest you pick some that don't already have the existing |
This is a proposed first step to remove needing to generate a table for each component separately. As part of this change I propose we also use the metadata to auto-generate the code to return the component status. Link issue: open-telemetry#19175 Signed-off-by: Alex Boten <aboten@lightstep.com>
I don't like how we split the scrapers in the hostmetrics receiver. I think we should have every component have only one metadata.yaml file. And I would like to suggest replacing the scrapers concept of hostmetrics receiver with metric groups that can be disabled/enabled explicitly the same way as currently done for metrics. (btw this will solve the issue in the helm chart where we cannot disable a scraper enabled by default cc @TylerHelmuth). @codeboten @djaglowski @mx-psi Let me know if you agree, and I'll create an issue to discuss the config interface. |
Makes sense to me @dmitryax, I think with that cleared out it's clear to me that this should go in mdatagen and just be the same file. |
I submitted #19440. Let me know if the description is unclear, and if I should elaborate more on some parts. Any suggestions/objections are welcome. |
This is a proposed first step to remove needing to generate a table for each component separately. As part of this change I propose we also use the metadata to auto-generate the code to return the component status. Link issue: open-telemetry#19175 Signed-off-by: Alex Boten <aboten@lightstep.com>
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
Let's keep this is open as a meta issue about metadata.yaml, will try to keep the description updated with all related issues. |
Pinging code owners for cmd/mdatagen: @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
It seems the main effort is complete. Should we close this one? |
Component(s)
No response
Describe the issue you're reporting
All components must have a status table describing their stability, supported pipeline types, available distributions and warnings (see #19172 for the latter). This is useful for end-users to understand how to use a component.
Currently, this table is on each component's README file which makes it difficult to ingest this information. I propose moving this table to a separate machine readable file so that
We can still generate the README table from the machine-readable file by placing a comment marking the position of the table.
To kickstart this we would need to:
Future work may include
The text was updated successfully, but these errors were encountered: