Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reciever/haproxy] Default resource attributes are not set on the emitted metrics #24920

Closed
dmitryax opened this issue Aug 5, 2023 · 3 comments · Fixed by #26702
Closed

[reciever/haproxy] Default resource attributes are not set on the emitted metrics #24920

dmitryax opened this issue Aug 5, 2023 · 3 comments · Fixed by #26702
Assignees
@sakulali
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed receiver/haproxy

Comments

@dmitryax
Copy link
Member

dmitryax commented Aug 5, 2023 •
edited
Loading

The following resource attributes defined in metadata.yaml as enabled by default but not being set on the emitted metrics: haproxy.url, haproxy.pid, haproxy.sid, haproxy.iid, haproxy.type, haproxy.algo. They should be either removed from metadata.yaml or set on the metrics.

Only haproxy.addr, haproxy.proxy_name and haproxy.service_name are used
@dmitryax dmitryax added bug Something isn't working receiver/haproxy labels Aug 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Pinging code owners for receiver/haproxy: @atoulme @MovieStoreGuy. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dmitryax dmitryax changed the title [reciever/haproxy] Default resource attributesyaml are not set on emitted metrics [reciever/haproxy] Default resource attributes are not set on the emitted metrics Aug 5, 2023
@dmitryax dmitryax added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 16, 2023
@sakulali
Copy link
Contributor

Hello @dmitryax , could you please assign this issue to me, i would like to spend some time resolving this feature, thanks

@sakulali sakulali mentioned this issue Sep 15, 2023
Merged
@codeboten
Copy link
Contributor

Thanks @sakulali!

codeboten pushed a commit that referenced this issue Sep 21, 2023
@sakulali
[reciever/haproxy] remove unused resource attributes (#26702)
b9d2a01 
#24920
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@sakulali @jmsnll
[reciever/haproxy] remove unused resource attributes (open-telemetry#…
d0de9d6 
…26702)

open-telemetry#24920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sakulali sakulali

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed receiver/haproxy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[reciever/haproxy] remove unused resource attributes sakulali/opentelemetry-collector-contrib
3 participants
@codeboten @sakulali @dmitryax