[exporter/clickhouse] Add persistent queue configuration to clickhouseexporter #27653
Assignees
Labels
Comments
fredthomsen
added
enhancement
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
fredthomsen
changed the title
|
It's unclear to me why the queue in this exporter was implemented in such a hardcoded way. It seems pretty reasonable to make it support the whole set of queue configurations. @fredthomsen do you want to submit a PR? |
|
@dmitryax I had the same question, and yes, I will submit a PR. |
fredthomsen
added a commit
to fredthomsen/opentelemetry-collector-contrib
that referenced
this issue
Oct 26, 2023
fredthomsen
added a commit
to fredthomsen/opentelemetry-collector-contrib
that referenced
this issue
Oct 27, 2023
|
Removing |
dmitryax
pushed a commit
that referenced
this issue
Oct 29, 2023
Addresses #27653. **Description:** Added persistent storage queue support by leveraging default `exporthelper.QueueSettings` config structure. **NOTE** This does end up being a **breaking** change to the API.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this issue
Nov 12, 2023
…8579) Addresses open-telemetry#27653. **Description:** Added persistent storage queue support by leveraging default `exporthelper.QueueSettings` config structure. **NOTE** This does end up being a **breaking** change to the API.
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this issue
Nov 24, 2023
…8579) Addresses open-telemetry#27653. **Description:** Added persistent storage queue support by leveraging default `exporthelper.QueueSettings` config structure. **NOTE** This does end up being a **breaking** change to the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
exporter/clickhouse
Is your feature request related to a problem? Please describe.
Currently the clickhouseexporter only supports setting
QueueSizefromexporterhelper.QueueSettings: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/clickhouseexporter/config.go#L81, thus in the event of the collector going down, data queued for export is not persisted.Describe the solution you'd like
Update clickhouseexporter configuration to add the ability to specify
*component.IDto enable persistence.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: