Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip linting for cmd/otelcontribcol cmd/oteltestbedcol #29449

Closed
codeboten opened this issue Nov 22, 2023 · 2 comments · Fixed by #29464
Closed

Skip linting for cmd/otelcontribcol cmd/oteltestbedcol #29449

codeboten opened this issue Nov 22, 2023 · 2 comments · Fixed by #29464
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command

Comments

@codeboten
Copy link
Contributor

Component(s)

cmd/otelcontribcol, cmd/oteltestbedcol

Describe the issue you're reporting

The linting for these components takes many minutes, we should skip linting these
@codeboten codeboten added the needs triage New item requiring triage label Nov 22, 2023
@atoulme
Copy link
Contributor

atoulme commented Nov 22, 2023

This replaces the work of #29308

@atoulme atoulme added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command and removed needs triage New item requiring triage labels Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for cmd/configschema: @mx-psi @dmitryax @pmcollins. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@codeboten codeboten mentioned this issue Nov 23, 2023
Merged
mx-psi pushed a commit that referenced this issue Nov 24, 2023
[chore] skip lint for cmd/otelcontribcol cmd/oteltestbedcol (#29464)
18b253c 
There isn't any value in linting these as their code is generated,
includes modules that are themselves linted, and they take a long time
to complete slowing down CI considerably.

Fixes #29449

The output looks something like:

```
make -C cmd/otelcontribcol lint
Makefile:4: warning: overriding commands for target `lint'
../../Makefile.Common:178: warning: ignoring old commands for target `lint'
running /Users/alex.boten/workspace/opentelemetry-collector-contrib/.tools/misspell -error
skipping lint
```

Signed-off-by: Alex Boten <aboten@lightstep.com>
@github-actions github-actions bot mentioned this issue Nov 28, 2023
Closed
98 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command
Projects
None yet
Milestone
No milestone
2 participants
@atoulme @codeboten