Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid go:build instructions #30461

Closed
atoulme opened this issue Jan 12, 2024 · 23 comments · Fixed by #30996
Closed

Remove invalid go:build instructions #30461

atoulme opened this issue Jan 12, 2024 · 23 comments · Fixed by #30996
Assignees
@kernelpanic77
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed receiver/aerospike receiver/couchdb receiver/elasticsearch receiver/hostmetrics receiver/kafkametrics receiver/kubeletstats receiver/memcached receiver/mongodb receiver/mongodbatlas receiver/nginx receiver/redis Redis related issues receiver/saphana receiver/zookeeper

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 12, 2024

Component(s)

No response

Describe the issue you're reporting

The following files contain instructions regarding Windows:

receiver/aerospikereceiver/doc.go://go:build !windows
receiver/couchdbreceiver/doc.go://go:build !windows
receiver/elasticsearchreceiver/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/cpuscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/diskscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/filesystemscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/loadscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/memoryscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/networkscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/pagingscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/processesscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/processscraper/doc.go://go:build !windows
receiver/kafkametricsreceiver/doc.go://go:build !windows
receiver/kubeletstatsreceiver/doc.go://go:build !windows
receiver/memcachedreceiver/doc.go://go:build !windows
receiver/mongodbatlasreceiver/doc.go://go:build !windows
receiver/mongodbreceiver/doc.go://go:build !windows
receiver/nginxreceiver/doc.go://go:build !windows
receiver/redisreceiver/doc.go://go:build !windows
receiver/saphanareceiver/doc.go://go:build !windows
receiver/zookeeperreceiver/doc.go://go:build !windows

Remove the following:

//go:build !windows
// +build !windows

from all those doc.go files as they should not be present.
@atoulme atoulme added the needs triage New item requiring triage label Jan 12, 2024
@crobert-1 crobert-1 added the bug Something isn't working label Jan 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/mongodbatlas: @djaglowski @schmikei. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/memcached: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/elasticsearch: @djaglowski @BinaryFissionGames. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/hostmetrics: @dmitryax @braydonk. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/redis: @dmitryax @hughesjj. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/nginx: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/mongodb: @djaglowski @schmikei. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/saphana: @dehaansa. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/couchdb: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/kubeletstats: @dmitryax @TylerHelmuth. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/zookeeper: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/aerospike: @djaglowski @antonblock. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/kafkametrics: @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme added the help wanted Extra attention is needed label Jan 12, 2024
@atoulme atoulme added the good first issue Good for newcomers label Jan 12, 2024
@github-actions github-actions bot mentioned this issue Jan 16, 2024
Closed
@hughesjj hughesjj mentioned this issue Jan 17, 2024
Merged
dmitryax pushed a commit that referenced this issue Jan 24, 2024
@hughesjj
[chore] remove !windows in build restriction for redis doc.go (#30632)
dfb6b17 
**Description:** removes dead code

**Link to tracking Issue:**
[30461](#30461)
@kernelpanic77
Copy link
Contributor

kernelpanic77 commented Jan 31, 2024 •
edited
Loading

Hi @atoulme! This seems like a stale issue. I'll like to work on this in case it still requires a PR.

@atoulme
Copy link
Contributor Author

atoulme commented Jan 31, 2024

@kernelpanic77 it's not stale. It's very much still a problem.

@atoulme
Copy link
Contributor Author

atoulme commented Jan 31, 2024 

$> git grep go:build | grep doc.go
receiver/aerospikereceiver/doc.go://go:build !windows
receiver/couchdbreceiver/doc.go://go:build !windows
receiver/elasticsearchreceiver/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/cpuscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/diskscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/filesystemscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/loadscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/memoryscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/networkscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/pagingscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/processesscraper/doc.go://go:build !windows
receiver/hostmetricsreceiver/internal/scraper/processscraper/doc.go://go:build !windows
receiver/kafkametricsreceiver/doc.go://go:build !windows
receiver/kubeletstatsreceiver/doc.go://go:build !windows
receiver/mongodbatlasreceiver/doc.go://go:build !windows
receiver/mongodbreceiver/doc.go://go:build !windows
receiver/nginxreceiver/doc.go://go:build !windows
receiver/zookeeperreceiver/doc.go://go:build !windows

@atoulme
Copy link
Contributor Author

atoulme commented Jan 31, 2024 •
edited
Loading

  • aerospikereceiver
  • couchdbreceiver
  • elasticsearchreceiver
  • hostmetricsreceiver
  • kafkametricsreceiver
  • kubeletstatsreceiver
  • mongodbatlasreceiver
  • mongodbreceiver
  • nginxreceiver
  • zookeeperreceiver

@atoulme
Copy link
Contributor Author

atoulme commented Jan 31, 2024

@kernelpanic77 all yours 🎉

@atoulme atoulme mentioned this issue Feb 1, 2024
Merged
@atoulme
Copy link
Contributor Author

atoulme commented Feb 1, 2024

Here is one to illustrate the changes needed: #30988 please feel free to review and approve if it's worth merging.

@djaglowski
Copy link
Member

Apologies for overlooking this issue. I'll open a PR against the rest of the components not covered in #30988

djaglowski pushed a commit that referenced this issue Feb 1, 2024
@atoulme
[chore] remove go build instructions on doc.go files (#30988)
b0c0f47 
Related to
#30461
@djaglowski djaglowski mentioned this issue Feb 1, 2024
Merged
djaglowski added a commit that referenced this issue Feb 1, 2024
@djaglowski
[chore] Remove invalid build tags from doc.go (#30996)
cff7eaa 
Resolves #30461
@kernelpanic77 kernelpanic77 mentioned this issue Feb 1, 2024
Closed
@kernelpanic77
Copy link
Contributor

@djaglowski I have opened a PR for rest of the components.

@djaglowski
Copy link
Member

@kernelpanic77, I apologize for missing that you had picked this up. I just noticed this morning it was opened three weeks ago and immediately opened up #30996 with the same changes.

cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
@hughesjj @cparkins
[chore] remove !windows in build restriction for redis doc.go (open-t…
1f704c2 
…elemetry#30632)

**Description:** removes dead code

**Link to tracking Issue:**
[30461](open-telemetry#30461)
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
@atoulme @cparkins
[chore] remove go build instructions on doc.go files (open-telemetry#…
34741f9 
…30988)

Related to
open-telemetry#30461
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
@djaglowski @cparkins
[chore] Remove invalid build tags from doc.go (open-telemetry#30996)
e000240 
Resolves open-telemetry#30461
@kernelpanic77
Copy link
Contributor

That's alright @djaglowski. I now see there are a couple of other PRs as well which are trying to fix the issue. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kernelpanic77 kernelpanic77

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed receiver/aerospike receiver/couchdb receiver/elasticsearch receiver/hostmetrics receiver/kafkametrics receiver/kubeletstats receiver/memcached receiver/mongodb receiver/mongodbatlas receiver/nginx receiver/redis Redis related issues receiver/saphana receiver/zookeeper
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] Remove invalid build tags from doc.go djaglowski/opentelemetry-collector-contrib
4 participants
@atoulme @djaglowski @kernelpanic77 @crobert-1