Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that all codeowners are members of the OpenTelemetry organization #30552

Closed
6 of 14 tasks
atoulme opened this issue Jan 15, 2024 · 16 comments · Fixed by #36229
Closed
6 of 14 tasks

Ensure that all codeowners are members of the OpenTelemetry organization #30552

atoulme opened this issue Jan 15, 2024 · 16 comments · Fixed by #36229
Labels
admin issues tracker issues etc. chore never stale Issues marked with this label will be never staled and automatically removed

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 15, 2024 •
edited
Loading

Component(s)

No response

Describe the issue you're reporting

See #20868 for the last campaign

Not all codeowners of this repository are members of the OpenTelemetry github organization, which membership is associated with membership of the OpenTelemetry project.

The guidelines enforce membership because it allows to assign and ping codeowners on issues or pull requests. Unfortunately, if you try to create an issue or assign a PR to a codeowner who is not member of OpenTelemetry, the workflow fails. I would like to fix this issue.

Going forward, I would also ideally like to make sure that we check that codeowners are members of the github organization whenever the codeowners file is touched.

The process to become a member of OpenTelemetry is straightforward. Open this issue template on the community project to get started.

I have identified a list of codeowners who are not currently members of OpenTelemetry. I will ping them in this issue below.

  1. Please cross your name to indicate you have seen this message.
  2. (optional) Please get in touch over Slack: I have created a slack channel for the purpose of codeowner discussions, #otel-collector. Feel free to reply here as well and provide clarifications if any information is incorrect.
  3. Please work towards membership. Feel free to use 2. for any questions.
  4. If I don't hear from you in the next 60 days (tentative), I will open an issue to follow up. The issue will offer to either help you become a member or open a pull request to move to emeritus status.

Thank you and apologies for the inconvenience.
@atoulme atoulme added the needs triage New item requiring triage label Jan 15, 2024
@braydonk
Copy link
Contributor

I am unable to check the checkbox for my name, but I have seen the issue.

#otel-collector-codeowners is an archived channel, will you be unarchiving it for this issue's purposes?

@github-actions github-actions bot mentioned this issue Jan 16, 2024
Closed
@braydonk
Copy link
Contributor

I am now a member of the OpenTelemetry GitHub Org.

@crobert-1
Copy link
Member

Just adding a couple reference issues

@braydonk - open-telemetry/community#1877
@zdaratom - open-telemetry/community#1876

@crobert-1 crobert-1 added chore admin issues tracker issues etc. and removed needs triage New item requiring triage labels Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Mar 18, 2024
@crobert-1 crobert-1 removed the Stale label Mar 18, 2024
@zdaratom-s1
Copy link
Contributor

"zdaratom" is no longer needed as it has been updated via #30639

@atoulme atoulme mentioned this issue Mar 31, 2024
Merged
@atoulme
Copy link
Contributor Author

atoulme commented Mar 31, 2024

I am unable to check the checkbox for my name, but I have seen the issue.

#otel-collector-codeowners is an archived channel, will you be unarchiving it for this issue's purposes?

Sorry, please use #otel-collector instead.

codeboten pushed a commit that referenced this issue Apr 3, 2024
@atoulme
[chore] Run a check on codeowners, backed by a github token (#32025)
a930320 
This PR introduces a check backed by a github token that tests the
content of .github/CODEOWNERS against the metadata of all the
components. Given that a token is used, and won't be present in builds
running with forks, this check is only made on the main branch of the
repository `open-telemetry/opentelemetry-collector-contrib`.

As such, I can't really test if it all works. The token is provisioned
by open-telemetry/community#1659. More context
in
#30552
@alxbl
Copy link
Member

alxbl commented Apr 30, 2024 •
edited
Loading

As of 2024/04/30:

$ githubgen
2024/04/30 10:50:08 codeowners are not members: 
Caleb-Hurshman, 
MaxKsyunz, 
MitchellGale, 
YANG-DB, 
adcharre, 
am-kinetica, 
asaharn, 
cheempz, 
driverpt, 
emreyalvac, 
jcreixell, 
jerrytfleung, 
rlankfo, 
shaochengwang, 
swar8080, 
thmshmm, 
yiyang5055, 
zpzhuSplunk

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jul 1, 2024
@alxbl
Copy link
Member

alxbl commented Jul 2, 2024

not stale, codeowners check should pass

@crobert-1 crobert-1 removed the Stale label Jul 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Sep 2, 2024
@crobert-1 crobert-1 added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Sep 3, 2024
This was referenced Nov 6, 2024
Closed
Merged
@atoulme
Copy link
Contributor Author

atoulme commented Nov 6, 2024

After a long wait, a few of the folks here are still not members of the OpenTelemetry organization. Unfortunately, it is time to move you to emeritus. See #36229

If you have any problem with this approach, please get in touch.

@emreyalvac
Copy link
Member

After a long wait, a few of the folks here are still not members of the OpenTelemetry organization. Unfortunately, it is time to move you to emeritus. See #36229

If you have any problem with this approach, please get in touch.

Sorry, I'm just seeing this now. Can i open a request?

@atoulme
Copy link
Contributor Author

atoulme commented Nov 6, 2024

@emreyalvac please do, please feel free to name me as one of your 2 sponsors.

@emreyalvac
Copy link
Member

Hi @atoulme,

Thank you very much for your understanding. I need one more sponsor. I am trying to find a sponsor.

open-telemetry/community#2429

@atoulme
Copy link
Contributor Author

atoulme commented Nov 10, 2024

@emreyalvac welcome and thank you for taking action!

@emreyalvac
Copy link
Member

@emreyalvac welcome and thank you for taking action!

Actually, I thank you for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
admin issues tracker issues etc. chore never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Milestone
No milestone
6 participants
@atoulme @alxbl @zdaratom-s1 @emreyalvac @crobert-1 @braydonk