Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/spanmetrics] Test TestConnectorConsumeTracesExpiredMetrics fails intermittently on actuated ARM runners #32395

Closed
crobert-1 opened this issue Apr 15, 2024 · 2 comments · Fixed by #33921
Assignees
Labels
arm64 Issues related to arm64 architecture connector/spanmetrics needs triage New item requiring triage Stale

Comments

@crobert-1
Copy link
Member

Component(s)

connector/spanmetrics

Describe the issue you're reporting

CI/CD failure link

Failure output:

Running target 'test-with-cover' in module 'connector/spanmetricsconnector' as part of group 'connector'
make --no-print-directory -C connector/spanmetricsconnector test-with-cover
mkdir -p /home/runner/actions-runner/_work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/coverage/unit
/home/runner/actions-runner/_work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum --rerun-fails=1 --packages="./..." -- -race -timeout 300s -parallel 4 --tags="" -cover -covermode=atomic -args -test.gocoverdir="/home/runner/actions-runner/_work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/coverage/unit"
∅  internal/metadata
✖  . (327ms)
✓  internal/cache (1.033s) (coverage: 73.1% of statements)
✓  internal/metrics (1.049s) (coverage: 35.4% of statements)
ERROR rerun aborted because previous run had a suspected panic and some test may not have run

=== Failed
=== FAIL: . TestConnectorConsumeTracesExpiredMetrics (0.01s)
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

goroutine 1091 [running]:
testing.tRunner.func1.2({0xafc560, 0xc00040c090})
	/home/runner/actions-runner/_work/_tool/go/1.21.9/arm64/src/testing/testing.go:1545 +0x2c8
testing.tRunner.func1()
	/home/runner/actions-runner/_work/_tool/go/1.21.9/arm64/src/testing/testing.go:1548 +0x4c4
panic({0xafc560?, 0xc00040c090?})
	/home/runner/actions-runner/_work/_tool/go/1.21.9/arm64/src/runtime/panic.go:920 +0x26c
github.com/open-telemetry/opentelemetry-collector-contrib/connector/spanmetricsconnector.TestConnectorConsumeTracesExpiredMetrics(0xc00040[89](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8694589952/job/23843888472#step:9:90)c0)
	/home/runner/actions-runner/_work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/connector/spanmetricsconnector/connector_test.go:1301 +0xcfc
testing.tRunner(0xc0004089c0, 0xbad8a0)
	/home/runner/actions-runner/_work/_tool/go/1.21.9/arm64/src/testing/testing.go:1595 +0x1b4
created by testing.(*T).Run in goroutine 1
	/home/runner/actions-runner/_work/_tool/go/1.21.9/arm64/src/testing/testing.go:1648 +0x5ec

=== FAIL: . TestLoadConfig (unknown)

=== FAIL: . TestConsumeTraces (unknown)

DONE 80 tests, 3 failures in 3.249s
make[2]: *** [../../Makefile.Common:131: test-with-cover] Error 3
make[1]: *** [Makefile:165: connector/spanmetricsconnector] Error 2
make: *** [Makefile:117: gotest-with-cover] Error 2
make[1]: Leaving directory '/home/runner/actions-runner/_work/opentelemetry-collector-contrib/opentelemetry-collector-contrib'
@crobert-1 crobert-1 added needs triage New item requiring triage arm64 Issues related to arm64 architecture labels Apr 15, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
As documented in this blog post
https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

The actuated runner has been causing build failures pretty consistently
on main. Possibly fix the following flaky tests:

Fixes
open-telemetry#32391
Fixes
open-telemetry#32395
Fixes
open-telemetry#32839

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm64 Issues related to arm64 architecture connector/spanmetrics needs triage New item requiring triage Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants