Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric tags are being dropped when using ObserverType: summary #3431

Closed
jatan28 opened this issue May 19, 2021 · 5 comments
Closed

Metric tags are being dropped when using ObserverType: summary #3431

jatan28 opened this issue May 19, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@jatan28
Copy link

jatan28 commented May 19, 2021

Currently, the statsd receiver supports the conversion of timings to either gauge/summary. While using gauge we can see that the tags of the original incoming metric are correctly translated to output metric labels but this does not happen when using summary which is seen https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/statsdreceiver/protocol/metric_translator.go#L71

Steps to reproduce
Use config:

statsd:
    endpoint: 0.0.0.0:<port>
    aggregation_interval: 60s
    enable_metric_type: false
    timer_histogram_mapping:
    - statsd_type: histogram
      observer_type: summary
    - statsd_type: timing
      observer_type: summary

And send timing metrics with labels. 
@jatan28 jatan28 added the bug Something isn't working label May 19, 2021
@gavindoudou
Copy link
Contributor

Thanks! The summary part does not have tags. I will add.

@gavindoudou
Copy link
Contributor

Are working on a fix, will have the PR tomorrow.

@gavindoudou
Copy link
Contributor

Fixed by that PR 3440.

@gavindoudou
Copy link
Contributor

Cam we close that?

alexperez52 referenced this issue in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@jmacd
Copy link
Contributor

jmacd commented Sep 30, 2021

Done.

@jmacd jmacd closed this as completed Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants