Fix StatsD drop metrics tags when using summary as observer_type for timer/histogram #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
approved these changes
May 21, 2021
bogdandrutu
previously requested changes
May 21, 2021
gavindoudou
force-pushed
the
statsdSummaryFix
branch
from
5a47104 to
fa161f9
Compare
Aneurysm9
reviewed
May 21, 2021
gavindoudou
force-pushed
the
statsdSummaryFix
branch
2 times, most recently
from
ad18d11 to
4544824
Compare
Aneurysm9
approved these changes
May 21, 2021
gavindoudou
force-pushed
the
statsdSummaryFix
branch
2 times, most recently
from
53c10dd to
1af2509
Compare
bogdandrutu
reviewed
May 26, 2021
gavindoudou
force-pushed
the
statsdSummaryFix
branch
from
1af2509 to
1cf2657
Compare
|
Can we merge it today? It's a bugfix. Thanks! |
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When sending timer/histogram using OTLP summary types, StatsD receiver does not send metrics tags. Add metrics tags when creating OTLP summary.
Deprecate
AppendwithAppendEmptyLink to tracking Issue:
#3431
Testing:
Added the test part for tags in creating OTLP summary metrics.
Documentation: