-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd/opampsupervisor]: Refactor NewSupervisor to take a config instead of a filepath #34379
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Removed |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
**Description:** Pass config structure to `NewSupervisor` instead of a file path. **Link to tracking Issue:** #34379 **Testing:** I run tests and adjusted the existing ones **Documentation:** - --------- Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Resolved by #34597 |
…#34597) **Description:** Pass config structure to `NewSupervisor` instead of a file path. **Link to tracking Issue:** open-telemetry#34379 **Testing:** I run tests and adjusted the existing ones **Documentation:** - --------- Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Component(s)
cmd/opampsupervisor
Describe the issue you're reporting
The supervisor currently takes in a path to a config file.
opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/supervisor.go
Line 141 in 20d6bae
Instead, it should take in a config struct (this config can be read from disk in main). This makes it easier to unit test and easier to use as a library, since the config would not need to be written to disk in order to run the supervisor.
The text was updated successfully, but these errors were encountered: