Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/opampsupervisor]: Refactor NewSupervisor to take a config instead of a filepath #34379

Closed
BinaryFissionGames opened this issue Aug 1, 2024 · 4 comments
Labels

Comments

@BinaryFissionGames
Copy link
Contributor

Component(s)

cmd/opampsupervisor

Describe the issue you're reporting

The supervisor currently takes in a path to a config file.

func NewSupervisor(logger *zap.Logger, configFile string) (*Supervisor, error) {

Instead, it should take in a config struct (this config can be read from disk in main). This makes it easier to unit test and easier to use as a library, since the config would not need to be written to disk in order to run the supervisor.

@BinaryFissionGames BinaryFissionGames added the needs triage New item requiring triage label Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1 crobert-1 added enhancement New feature or request and removed needs triage New item requiring triage labels Aug 1, 2024
@crobert-1
Copy link
Member

Removed needs triage as this makes sense to me, was filed by a code owner, and another code owner responded with +1.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 1, 2024
evan-bradley added a commit that referenced this issue Oct 1, 2024
**Description:** Pass config structure to `NewSupervisor` instead of a
file path.

**Link to tracking Issue:** #34379

**Testing:** I run tests and adjusted the existing ones

**Documentation:** -

---------

Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
@crobert-1
Copy link
Member

Resolved by #34597

jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
…#34597)

**Description:** Pass config structure to `NewSupervisor` instead of a
file path.

**Link to tracking Issue:** open-telemetry#34379

**Testing:** I run tests and adjusted the existing ones

**Documentation:** -

---------

Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants