Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8sprocessor] Watch pods in a set of namespaces #4623

Closed
gebn opened this issue Aug 13, 2021 · 4 comments
Closed

[k8sprocessor] Watch pods in a set of namespaces #4623

gebn opened this issue Aug 13, 2021 · 4 comments
Labels
closed as inactive enhancement New feature or request help wanted Extra attention is needed processor/k8sattributes k8s Attributes processor Stale

Comments

@gebn
Copy link
Contributor

gebn commented Aug 13, 2021

Is your feature request related to a problem? Please describe.

The processor is currently able to watch pods in a single namespace, on a single node, or across the entire cluster. In multi-tenant clusters, watching every pod is at best inefficient and worst forbidden, while looking at a single node is best-suited for DaemonSet deployments. This means the only option left is to have a processor or collector for each namespace of a multi-namespace application.

Describe the solution you'd like

It would be great if instead of a single namespace as is currently the case:

k8s_tagger:
  filter:
    namespace: foo

A list of namespaces could be passed:

k8s_tagger:
  filter:
    namespaces:
    - foo
    - bar
    - baz

Describe alternatives you've considered

  • Run an OTel Collector deployment per namespace, either consolidated in a single namespace, or in the respective namespaces.
  • Configure an instance of k8s_tagger for each namespace and list them in the pipeline, assuming the correct one will pick up a given pod and all others will ignore it.
  • Configure a distinct pipeline for each namespace, each with a k8s_tagger instance filtering by that namespace. Each could use a receiver listening on a dedicated port.

Additional context

Prometheus's K8s service discovery is capable of watching multiple namespaces at once:

kubernetes_sd_configs:
- namespaces:
    names:
    - foo
    - bar
    - baz
@alolita alolita added the processor/k8sattributes k8s Attributes processor label Sep 30, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 4, 2022
@dmitryax dmitryax removed the Stale label Nov 4, 2022
@dmitryax
Copy link
Member

dmitryax commented Nov 4, 2022

This feature request makes sense but we don't have enough capacity to work on it at this point. Any help is appreciated. Should be implemented once we have e2e tests in place tho #15651

@dmitryax dmitryax added enhancement New feature or request help wanted Extra attention is needed labels Nov 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 4, 2023
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed as inactive enhancement New feature or request help wanted Extra attention is needed processor/k8sattributes k8s Attributes processor Stale
Projects
None yet
Development

No branches or pull requests

3 participants