-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce e2e tests for kubernetes story #15651
Comments
@povilasv as we discussed, PTAL if it makes sense and if you can work on it |
This is cool! Makes sense to me. Do we have something similar somewhere else I can use to bootstrap this? I can find some time to work on this |
https://github.com/open-telemetry/opentelemetry-helm-charts has some smoke tests spinning up a cluster and installing the charts, so they can be used as a starting point |
@povilasv please let us know if you have time to work on this, otherwise, we will look if someone else can take it |
Hey, I've started to look into this. Sorry for delay had some public holidays and other work stuff :) |
@dmitryax I've started playing with k8s e2e test framework -> https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/16263/files#diff-92cca7ce2020408b9bcd2fd0eb8d457505f31cebf5e124e2b9cf6f053dd7f19eR47 ATM have it spin up a simple collector deployment. I kind of like the way it's structured. Do you have any opinions around e2e framework ?:) |
Writing update:
I'm still thinking how to work around this? Sorry folks for blocking PRs, somehow I keep hitting obstacle after obstacle with no good solution :/ |
For this question, could we consider only build image locally, but instead of pushing to docker hub, we just use |
Any progress? @povilasv |
Do you have time on this? @povilasv If not, I'm willing to continue on this work. |
Hey @fatsheep9146 , got sick and now side tracked by other projects. It would be best if you could take over. Sorry and thank you! |
I agree, we can build a small image locally with needed components only and use it in the kind cluster for testing. |
Yes, I already tried to do like in this way, but encounter some questions to be solved. |
@fatsheep9146 Thank you for taking care of it! And feel free to share your findings here |
hi @dmitryax @povilasv #17410 the whole workflow basically contains following steps
Since this version is used to verify the solution, some codes are not very carefully wrote, feel free to give any comments. |
This is an amazing start! Thanks a lot, @fatsheep9146! |
@fatsheep9146 @povilasv I created items for other k8s components. Feel free to add more tickets or take those that are unassigned |
I will start to complete other items :) |
This is awesome :) By the way, should we also enhance the k8sattribute tests and check for common cases like Deployments / StatefulSets / DaemonSets? |
Yes, I agree with that, feel free to make a contribution :) |
Problem statement
Kubernetes related components, especially k8s attributes processor are used pretty extensively in the field. At the same time they don't have good e2e test coverage. Recently we had a significant change that introduced a few regressions. We want to make sure that such regressions are caught by CICD going forward.
Proposed solution
We need to introduce a GitHub actions job that would spin up a k8s cluster with a collector built from the current branch.
Proposed steps:
Action items
Once it's introduced in the contrib repo, we can potentially reuse the same tests in the helm repo.
The text was updated successfully, but these errors were encountered: