Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [processor/k8sattributes] Rework Kubernetes e2e tests #20427

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

dmitryax
Copy link
Member

Update Kubernetes end-to-end tests by applying the following enhancements:

  • Make it possible to run tests locally. Keep only kind cluster and pre-built image as the test prerequisites.
  • Remove dependency on the helm chart. Install only required k8s objects from pre-defined manifests.
  • Remove the OTLP JSON files as a medium and send OTLP metrics/traces/logs directly to the consumers spun up in the test.
  • Remove statically set k8s.containet.restart_count attribute to reduce flakiness. Let the processor use the latest container instead.
  • Combine separate tests for traces, metrics and logs into one to reduce execution time.
  • Make the test faster by waiting for the predefined number of metrics/traces/logs instead of static sleep time.

@dmitryax dmitryax requested a review from a team March 28, 2023 03:13
@github-actions github-actions bot added cmd/telemetrygen telemetrygen command processor/k8sattributes k8s Attributes processor labels Mar 28, 2023
@runforesight
Copy link

runforesight bot commented Mar 28, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(5 seconds) has decreased 32 minutes 2 seconds compared to main branch avg(32 minutes 7 seconds).
View More Details

⭕  changelog workflow has finished in 5 seconds (2 minutes 9 seconds less than main branch avg.) and finished at 5th Apr, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 5 seconds (32 minutes 2 seconds less than main branch avg.) and finished at 5th Apr, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  check-links workflow has finished in 47 seconds and finished at 5th Apr, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 1 minute 3 seconds and finished at 5th Apr, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 7 seconds (3 minutes 12 seconds less than main branch avg.) and finished at 5th Apr, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  N/A See Details

✅  load-tests workflow has finished in 6 minutes 50 seconds (3 minutes 29 seconds less than main branch avg.) and finished at 5th Apr, 2023.


Job Failed Steps Tests
setup-environment -     🔗  N/A See Details
loadtest (TestIdleMode) -     🔗  N/A See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  N/A See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  N/A See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  N/A See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  N/A See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  N/A See Details
loadtest (TestTraceAttributesProcessor) -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 13 minutes 38 seconds and finished at 5th Apr, 2023.


Job Failed Steps Tests
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details

✅  build-and-test workflow has finished in 35 minutes 46 seconds (10 minutes 37 seconds less than main branch avg.) and finished at 5th Apr, 2023.


Job Failed Steps Tests
setup-environment -     🔗  N/A See Details
checks -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (connector) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
correctness-metrics -     🔗  N/A See Details
correctness-traces -     🔗  N/A See Details
integration-tests -     🔗  N/A See Details
unittest-matrix (1.20, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.20, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.20, processor) -     🔗  N/A See Details
unittest-matrix (1.20, exporter) -     🔗  N/A See Details
unittest-matrix (1.20, extension) -     🔗  N/A See Details
unittest-matrix (1.20, connector) -     🔗  N/A See Details
unittest-matrix (1.20, internal) -     🔗  N/A See Details
unittest-matrix (1.20, other) -     🔗  N/A See Details
unittest-matrix (1.19, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.19, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.19, processor) -     🔗  N/A See Details
unittest-matrix (1.19, exporter) -     🔗  N/A See Details
unittest-matrix (1.19, extension) -     🔗  N/A See Details
unittest-matrix (1.19, connector) -     🔗  N/A See Details
unittest-matrix (1.19, internal) -     🔗  N/A See Details
unittest-matrix (1.19, other) -     🔗  N/A See Details
lint -     🔗  N/A See Details
unittest (1.20) -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
rotate-milestone -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/datadog Datadog components labels Mar 28, 2023
@dmitryax dmitryax force-pushed the rework-e2e-tests branch 3 times, most recently from 5c101cc to 26a48d5 Compare March 28, 2023 05:21
@dmitryax
Copy link
Member Author

dmitryax commented Apr 4, 2023

@fatsheep9146 PTAL

@mx-psi mx-psi requested a review from fatsheep9146 April 5, 2023 09:10
@fatsheep9146
Copy link
Contributor

Totally LGTM except for above two comments.

Update Kubernetes end-to-end tests applying the following enhancements:
- Make it possible to run tests locally. Keep only kind cluster and pre-built image as the test prerequisites.
- Remove dependency on the helm chart, install only required k8s objects from pre-defined manifests.
- Remove the OTLP json files as a medium and send OTLP metrics/traces/logs directly to the consumers spun up in the test.
- Remove statically set `k8s.containet.restart_count` attribute to reduce flakiness. Let the processor use the latest container instead.
- Combine separate tests for traces, metrics and logs into one to reduce execution time.
- Make the test faster by waiting for predefined number of metrics/traces/logs instead of static sleep time.
@dmitryax dmitryax merged commit 52a9d72 into open-telemetry:main Apr 5, 2023
@github-actions github-actions bot added this to the next release milestone Apr 5, 2023
@dmitryax dmitryax deleted the rework-e2e-tests branch April 6, 2023 03:22
@TylerHelmuth
Copy link
Member

Related to #15651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command cmd/telemetrygen telemetrygen command exporter/datadog Datadog components processor/k8sattributes k8s Attributes processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants