-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential memory leak in prometheus receiver #9278
Comments
@gouthamve is investigating |
We have already tagged |
@gouthamve was the potential memory leak introduced after v0.48.0? I see only this dependency update https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/8780/files#diff-cbc1780ee44619ffeeb078f84991774b14445d3a192c34b6acc709f00788b421R390 |
Yes, that dependency update was to pull in prometheus/prometheus#10450 and prometheus/prometheus#10473 to allow access to target info and metric metadata even after |
We should retract both the main module as well as (at least) the modules that depend on prometheus |
@gouthamve do you have any update on this? |
Cross posting update from @gouthamve in CNCF Slack:
|
Decision was made during the SIG meeting to not block the release by this issue. The warning about this issue was added to the 0.49.0 release notes. |
Prometheus started doing proper go.mod publishing and started off with v0.35, but this means the previous version was "winning" as it was v1.8.2 so I had to update the version everywhere. This brings in prometheus/prometheus#10636 which fixes open-telemetry#9278 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Prometheus started doing proper go.mod publishing and started off with v0.35, but this means the previous version was "winning" as it was v1.8.2 so I had to update the version everywhere. This brings in prometheus/prometheus#10636 which fixes open-telemetry#9278 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
* Update Prometheus to not have memory leak. Prometheus started doing proper go.mod publishing and started off with v0.35, but this means the previous version was "winning" as it was v1.8.2 so I had to update the version everywhere. This brings in prometheus/prometheus#10636 which fixes #9278 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
* Update Prometheus to not have memory leak. Prometheus started doing proper go.mod publishing and started off with v0.35, but this means the previous version was "winning" as it was v1.8.2 so I had to update the version everywhere. This brings in prometheus/prometheus#10636 which fixes open-telemetry#9278 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Since the issue is closed, does it mean the warning "The issue is currently being investigated and will be fixed in one of the new releases. More details: #9278." in https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/prometheusreceiver is now obsolete? |
Yes, we can remove that status header |
I opened #11050 |
Investigate whether the prometheus receiver is impacted by the memory leak addressed by the following fix: prometheus/prometheus#10590
Note: the 0.49.0 release is blocked pending the investigation
The text was updated successfully, but these errors were encountered: