Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/prometheusremotewrite] Dead links #11141

Merged
merged 1 commit into from
Jun 22, 2022
Merged

[exporter/prometheusremotewrite] Dead links #11141

merged 1 commit into from
Jun 22, 2022

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Jun 18, 2022

fix: #10979

@my-git9 my-git9 requested a review from a team June 18, 2022 05:26
@my-git9 my-git9 requested a review from Aneurysm9 as a code owner June 18, 2022 05:26
@my-git9
Copy link
Member Author

my-git9 commented Jun 21, 2022

/cc @djaglowski @bogdandrutu

@djaglowski
Copy link
Member

Another link on this component appears to be failing.

FILE: exporter/prometheusremotewriteexporter/DESIGN.md
  [✓] https://cortexmetrics.io/docs/api/ → Status: 200
  [✓] https://docs.influxdata.com/influxdb/v1.8/supported_protocols/prometheus/ → Status: 200
  [✓] https://prometheus.io/docs/operating/integrations/#remote-endpoints-and-storage → Status: 200
  [✓] https://github.com/prometheus/prometheus/blob/master/prompb/remote.proto#L22 → Status: 200
  [✓] https://prometheus.io/docs/prometheus/latest/storage/#overview → Status: 200
  [✓] https://github.com/open-telemetry/opentelemetry-collector/issues/[12](https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6946077624?check_suite_focus=true#step:4:13)55 → Status: 200
  [✖] https://github.com/open-telemetry/opentelemetry-collector/issues/1422 → Status: 404
  [✓] https://github.com/open-telemetry/opentelemetry-specification/issues/731 → Status: 200
  [✓] https://github.com/spf[13](https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6946077624?check_suite_focus=true#step:4:14)/viper → Status: 200
  [✓] #12-gaps-and-assumptions → Status: 200
  [✓] img/cortex.png → Status: 200
  [✓] img/timeseries.png → Status: 200
  12 links checked.
  ERROR: 1 dead links found!
  [✖] https://github.com/open-telemetry/opentelemetry-collector/issues/[14](https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6946077624?check_suite_focus=true#step:4:15)[22](https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6946077624?check_suite_focus=true#step:4:23) → Status: 404
Check that anchor links are lowercase
Error: Process completed with exit code 1.

@my-git9 my-git9 force-pushed the prometheusreceiver2 branch from 5655785 to 946f8aa Compare June 21, 2022 13:38
@my-git9
Copy link
Member Author

my-git9 commented Jun 21, 2022

Another link on this component appears to be failing.

FILE: exporter/prometheusremotewriteexporter/DESIGN.md
  [✓] https://cortexmetrics.io/docs/api/ → Status: 200
  [✓] https://docs.influxdata.com/influxdb/v1.8/supported_protocols/prometheus/ → Status: 200
  [✓] https://prometheus.io/docs/operating/integrations/#remote-endpoints-and-storage → Status: 200
  [✓] https://github.com/prometheus/prometheus/blob/master/prompb/remote.proto#L22 → Status: 200
  [✓] https://prometheus.io/docs/prometheus/latest/storage/#overview → Status: 200
  [✓] https://github.com/open-telemetry/opentelemetry-collector/issues/[12](https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6946077624?check_suite_focus=true#step:4:13)55 → Status: 200
  [✖] https://github.com/open-telemetry/opentelemetry-collector/issues/1422 → Status: 404
  [✓] https://github.com/open-telemetry/opentelemetry-specification/issues/731 → Status: 200
  [✓] https://github.com/spf[13](https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6946077624?check_suite_focus=true#step:4:14)/viper → Status: 200
  [✓] #12-gaps-and-assumptions → Status: 200
  [✓] img/cortex.png → Status: 200
  [✓] img/timeseries.png → Status: 200
  12 links checked.
  ERROR: 1 dead links found!
  [✖] https://github.com/open-telemetry/opentelemetry-collector/issues/[14](https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6946077624?check_suite_focus=true#step:4:15)[22](https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6946077624?check_suite_focus=true#step:4:23) → Status: 404
Check that anchor links are lowercase
Error: Process completed with exit code 1.

Thanks for your review, this issue https://github.com/open-telemetry/opentelemetry-collector/issues/1422 seems miss.
Shoud we delete the link or a whole sentence？

@djaglowski
Copy link
Member

I'm not familiar enough with this component to suggest that we should change the contents of the readme. Ideally, we will figure out why this link is reported as dead and make the appropriate change. (I don't see why the tool suggests it is 404, but we should figure this out if possible.)

@my-git9
fix dead links
0a4e9c7 
Signed-off-by: xin.li <xin.li@daocloud.io>
@my-git9 my-git9 force-pushed the prometheusreceiver2 branch from 946f8aa to 0a4e9c7 Compare June 21, 2022 15:03
@my-git9
Copy link
Member Author

my-git9 commented Jun 21, 2022

I'm not familiar enough with this component to suggest that we should change the contents of the readme. Ideally, we will figure out why this link is reported as dead and make the appropriate change. (I don't see why the tool suggests it is 404, but we should figure this out if possible.)

I found the issue: #4968
The pr: https://github.com/open-telemetry/opentelemetry-collector/pull/1422 will be redirect to issue:#4968

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 22, 2022
@djaglowski djaglowski merged commit 3e41bdb into open-telemetry:main Jun 22, 2022
@my-git9 my-git9 mentioned this pull request Jul 5, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees

@bogdandrutu bogdandrutu

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[exporter/prometheusremotewrite] Dead links
3 participants
@my-git9 @djaglowski @bogdandrutu