Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadog] Remove deprecated configuration features #12110

Merged
merged 11 commits into from
Jul 11, 2022
Merged

[exporter/datadog] Remove deprecated configuration features #12110

merged 11 commits into from
Jul 11, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jul 6, 2022 •
edited
Loading

@mx-psi mx-psi mentioned this pull request Jul 6, 2022
Merged
@mx-psi
[exporter/datadog] Remove deprecated configuration features
f4105d2 
This includes both the environment variable detection as well as
the deprecated settings.
@mx-psi mx-psi force-pushed the mx-psi/remove-deprecated-options branch from b2200c4 to f4105d2 Compare July 6, 2022 11:10
@mx-psi mx-psi marked this pull request as ready for review July 7, 2022 11:46
@mx-psi mx-psi requested review from a team and codeboten July 7, 2022 11:46
@mx-psi mx-psi requested a review from gbbr July 7, 2022 11:56
gbbr
gbbr reviewed Jul 7, 2022
View reviewed changes
Copy link
Member

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, but looks good overall.

exporter/datadogexporter/config.go Show resolved Hide resolved
exporter/datadogexporter/config.go Outdated Show resolved Hide resolved
unreleased/mx-psi-remove-deprecated-options.yaml Outdated Show resolved Hide resolved
exporter/datadogexporter/config.go Outdated Show resolved Hide resolved
exporter/datadogexporter/config.go Outdated Show resolved Hide resolved
exporter/datadogexporter/config.go Outdated Show resolved Hide resolved
@mx-psi mx-psi requested a review from gbbr July 7, 2022 15:18
gbbr
gbbr approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Feel free to disregard the final comment since this is not new code and its an improvement never the less. I'll leave it up to you.

exporter/datadogexporter/config.go Outdated Show resolved Hide resolved
@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Jul 11, 2022
gbbr
gbbr approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mx-psi mx-psi removed the ready to merge Code review completed; ready to merge by maintainers label Jul 11, 2022
@mx-psi mx-psi merged commit c62a9a8 into open-telemetry:main Jul 11, 2022
@mx-psi mx-psi deleted the mx-psi/remove-deprecated-options branch July 11, 2022 13:42
@mx-psi mx-psi mentioned this pull request Jul 19, 2022
Merged
@mx-psi mx-psi mentioned this pull request Mar 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbr gbbr gbbr approved these changes

@dashpole dashpole dashpole approved these changes

@codeboten codeboten Awaiting requested review from codeboten

Assignees

@dashpole dashpole

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mx-psi @dashpole @gbbr