prometheusreceiver: remove storing pointers to pdata, allow removing pdata copy #13922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
a team,
Aneurysm9 and
dashpole
as code owners
bogdandrutu
force-pushed
the
rmpointers
branch
from
53e3f47
to
85eb767
Compare
bogdandrutu
force-pushed
the
rmpointers
branch
from
85eb767
to
413b195
Compare
…pdata copy Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
rmpointers
branch
from
413b195
to
2259bb4
Compare
MovieStoreGuy
approved these changes
Sep 7, 2022
jmacd
approved these changes
Sep 7, 2022
dashpole
approved these changes
Sep 7, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also helps with memory usage overall, since we are removing the reference to the data point attributes which is probably one of the major cause of the memory usage.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com