Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Consistent copyright first line #14461

Merged
merged 1 commit into from
Sep 25, 2022
Merged

[chore] Consistent copyright first line #14461

merged 1 commit into from
Sep 25, 2022

Conversation

bogdandrutu
Copy link
Member

  • Remove year, we don't have that in majority of the files
  • Remove double space between "Copyright" and "The"

@bogdandrutu bogdandrutu requested a review from a team September 23, 2022 15:18
@dashpole
Copy link
Contributor

Do we have a copyright checker?

@bogdandrutu
Copy link
Member Author

We do, but all these pass, because the copyright is present and year is not mandatory for the check.

@dashpole
Copy link
Contributor

Can we disallow the year to keep it consistent? Or maybe it isn't worth it

@djaglowski
Copy link
Member

I agree this is the better format, but want to note that the addlicense tool generates the double space, so we'll continue to see this in new files without an additional change.

@djaglowski
Copy link
Member

Looks like the extra space issue was addressed recently, but the change has not yet been released.

@bogdandrutu
[chore] Consistent copyright first line
1374134 
* Remove year, we don't have that in majority of the files
* Remove double space between "Copyright" and "The"

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 0ea5dc4 into open-telemetry:main Sep 25, 2022
@bogdandrutu bogdandrutu deleted the copyright branch September 25, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@codeboten codeboten codeboten approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

Assignees

@dmitryax dmitryax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bogdandrutu @dashpole @djaglowski @codeboten @dmitryax