Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

receiver/mysql: add metrics based on events_statements_summary_by_digest table #14477

Merged
merged 1 commit into from
Oct 18, 2022
Merged

receiver/mysql: add metrics based on events_statements_summary_by_digest table #14477

merged 1 commit into from
Oct 18, 2022

Conversation

sumo-drosiek
Copy link
Member

@sumo-drosiek sumo-drosiek commented Sep 26, 2022 •
edited
Loading

Description:

Adds equivalent of the following telegraf metrics:

mysql_perf_schema_events_statements_errors_total
mysql_perf_schema_events_statements_no_index_used_total
mysql_perf_schema_events_statements_rows_affected_total
mysql_perf_schema_events_statements_rows_examined_total
mysql_perf_schema_events_statements_rows_sent_total
mysql_perf_schema_events_statements_seconds_total
mysql_perf_schema_events_statements_sort_merge_passes_total
mysql_perf_schema_events_statements_sort_rows_total
mysql_perf_schema_events_statements_tmp_disk_tables_total
mysql_perf_schema_events_statements_tmp_tables_total
mysql_perf_schema_events_statements_warnings_total

mysql documentation: https://dev.mysql.com/doc/refman/5.7/en/performance-schema-statement-summary-tables.html

Link to tracking Issue: #14138

Testing: Units

Documentation: auto-generated

@sumo-drosiek sumo-drosiek marked this pull request as ready for review September 26, 2022 12:39
@sumo-drosiek sumo-drosiek requested a review from a team September 26, 2022 12:39
@sumo-drosiek sumo-drosiek force-pushed the drosiek-mysql-perf-metrics branch from 0064800 to a2d4bd2 Compare September 27, 2022 11:45
djaglowski
djaglowski reviewed Sep 27, 2022
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some nits about naming / consistency with other metrics in this receiver.

receiver/mysqlreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/mysqlreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/mysqlreceiver/README.md Outdated Show resolved Hide resolved
@sumo-drosiek sumo-drosiek force-pushed the drosiek-mysql-perf-metrics branch from d68b137 to 8603579 Compare September 28, 2022 06:41
djaglowski
djaglowski reviewed Sep 28, 2022
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, w/ one typo fix

receiver/mysqlreceiver/README.md Outdated Show resolved Hide resolved
dmitryax
dmitryax reviewed Sep 28, 2022
View reviewed changes
receiver/mysqlreceiver/documentation.md Outdated Show resolved Hide resolved
receiver/mysqlreceiver/documentation.md Outdated Show resolved Hide resolved
@sumo-drosiek sumo-drosiek force-pushed the drosiek-mysql-perf-metrics branch from 103f9b9 to e49b466 Compare September 30, 2022 06:50
@sumo-drosiek sumo-drosiek requested a review from dmitryax October 3, 2022 06:45
@sumo-drosiek sumo-drosiek force-pushed the drosiek-mysql-perf-metrics branch from e49b466 to 24cde04 Compare October 7, 2022 06:24
@sumo-drosiek sumo-drosiek force-pushed the drosiek-mysql-perf-metrics branch 2 times, most recently from 22d9f20 to 73cc7d6 Compare October 10, 2022 14:16
djaglowski
djaglowski reviewed Oct 10, 2022
View reviewed changes
receiver/mysqlreceiver/client.go Outdated Show resolved Hide resolved
receiver/mysqlreceiver/client.go Outdated Show resolved Hide resolved
receiver/mysqlreceiver/client.go Outdated Show resolved Hide resolved
receiver/mysqlreceiver/client.go Outdated Show resolved Hide resolved
receiver/mysqlreceiver/client.go Outdated Show resolved Hide resolved
@sumo-drosiek sumo-drosiek force-pushed the drosiek-mysql-perf-metrics branch 2 times, most recently from 2809110 to c46535f Compare October 11, 2022 06:45
codeboten
codeboten reviewed Oct 14, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve the conflicts for this PR and any comments that have already been addressed 👍🏻

@djaglowski
receiver/mysql: add metrics based on events_statements_summary_by_dig…
dd9e3d1 
…est table

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-mysql-perf-metrics branch from c46535f to dd9e3d1 Compare October 17, 2022 06:14
@sumo-drosiek
Copy link
Member Author

@codeboten should be fine now

@dmitryax dmitryax merged commit 67380fc into open-telemetry:main Oct 18, 2022
sumo-drosiek added a commit to SumoLogic/opentelemetry-collector-contrib that referenced this pull request Oct 19, 2022
@sumo-drosiek @djaglowski
receiver/mysql: add metrics based on events_statements_summary_by_dig…
65c7260 
…est table (open-telemetry#14477)

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
@sumo-drosiek sumo-drosiek mentioned this pull request Oct 19, 2022
Merged
sumo-drosiek added a commit to SumoLogic/opentelemetry-collector-contrib that referenced this pull request Oct 20, 2022
@sumo-drosiek @djaglowski
receiver/mysql: add metrics based on events_statements_summary_by_dig…
7518b0b 
…est table (open-telemetry#14477)

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@sumo-drosiek @djaglowski @shalper2
receiver/mysql: add metrics based on events_statements_summary_by_dig…
31f3c28 
…est table (open-telemetry#14477)

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@codeboten codeboten codeboten left review comments

@dmitryax dmitryax dmitryax approved these changes

Assignees

@dmitryax dmitryax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sumo-drosiek @codeboten @djaglowski @dmitryax