[receiver/mysql] Add mysql.connection.count metric #14736
Conversation
djaglowski
changed the title
sumo-drosiek
force-pushed
the
drosiek-mysql-connection-count
branch
from
d749642 to
f627dc2
Compare
receiver/mysqlreceiver/metadata.yaml
Outdated
| @@ -283,6 +283,15 @@ metrics: | |||
| monotonic: false | |||
| aggregation: cumulative | |||
| attributes: [threads] | |||
| mysql.connection.count: | |||
| enabled: true | |||
There was a problem hiding this comment.
Do we want to enable this? It is always hard to disable later, and I feel that we almost enable everything.
There was a problem hiding this comment.
The comment is not to block this PR, but to ensure that someone starts thinking about this and makes a proposal.
There was a problem hiding this comment.
So far, my heuristics for disabling metrics by default have been for things like:
- If it creates high cardinality of resources and/or data points
- If there is a notable expected performance impact
- If there is unusual configuration required (on monitored system or collector)
In general, I think of metrics as otherwise being pretty cheap, but I agree we should probably establish some kind of limitations based on how valuable a metric is vs others.
There was a problem hiding this comment.
Should it go as enabled, or should I disable it and we can enable them in separate PR eventually?
There was a problem hiding this comment.
@djaglowski @bogdandrutu
Disabled metric by default and rebased the branch
sumo-drosiek
force-pushed
the
drosiek-mysql-connection-count
branch
from
f627dc2 to
8dacef5
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-mysql-connection-count
branch
from
8dacef5 to
33bc97d
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
@djaglowski @bogdandrutu can we reopen and merge this PR? |
|
@sumo-drosiek I cannot reopen the PR, but will happily accept a new one. Looks like all concerns were addressed here and this was just forgotten about. |
Description:
add mysql.connection.count metric
Link to tracking Issue:
#14138
Testing:
unit tests
Documentation:
metadata.yaml