-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/mysql]: add mysql.client.network.io metric #14744
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
changed the title
feat(mysqlreceiver): add mysql.bytes.count metric
[receiver/mysql]: add mysql.bytes.count metric
Oct 7, 2022
sumo-drosiek
force-pushed
the
drosiek-mysql-bytes
branch
from
October 7, 2022 06:45
2a65f25
to
f351d6b
Compare
djaglowski
reviewed
Oct 7, 2022
sumo-drosiek
force-pushed
the
drosiek-mysql-bytes
branch
from
October 10, 2022 14:05
f351d6b
to
d87b752
Compare
sumo-drosiek
changed the title
[receiver/mysql]: add mysql.bytes.count metric
[receiver/mysql]: add mysql.client_throughput.count metric
Oct 10, 2022
sumo-drosiek
force-pushed
the
drosiek-mysql-bytes
branch
3 times, most recently
from
October 11, 2022 06:53
8ec96e7
to
cf4b527
Compare
sumo-drosiek
force-pushed
the
drosiek-mysql-bytes
branch
from
October 19, 2022 05:23
cf4b527
to
6091e81
Compare
sumo-drosiek
changed the title
[receiver/mysql]: add mysql.client_throughput.count metric
[receiver/mysql]: add mysql.client.network.io metric
Oct 19, 2022
sumo-drosiek
force-pushed
the
drosiek-mysql-bytes
branch
from
October 19, 2022 06:46
6091e81
to
b823670
Compare
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-mysql-bytes
branch
from
October 19, 2022 06:50
b823670
to
4887b9c
Compare
djaglowski
approved these changes
Oct 21, 2022
@@ -75,6 +75,10 @@ attributes: | |||
index_name: | |||
value: index | |||
description: The name of the index. | |||
transmission_direction: | |||
value: kind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, this should be direction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added fixed code as part of #15366
Closed based on #15366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
add mysql.bytes.count metric
Link to tracking Issue:
#14138
Testing:
unit tests
Documentation:
metadata.yaml