Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWSEMFExporter - Add collector version to EMF exporter user agent #1778

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

shaochengwang
Copy link
Contributor

Description:
Add collector version to EMF exporter user agent
Similar implementation as in #1730. To provide support to customers using the otel collector, we need some more telemetry data from the collector. Adding the collector version to user agent is the first simple step.

Testing:
Unit tests

Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #1778 (6d43a96) into master (56652dc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1778   +/-   ##
=======================================
  Coverage   89.84%   89.85%           
=======================================
  Files         376      376           
  Lines       18205    18209    +4     
=======================================
+ Hits        16357    16361    +4     
  Misses       1387     1387           
  Partials      461      461           
Flag Coverage Δ
integration 69.84% <ø> (+0.06%) ⬆️
unit 88.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/awsemfexporter/cwlog_client.go 100.00% <100.00%> (ø)
exporter/awsemfexporter/emf_exporter.go 100.00% <100.00%> (ø)
exporter/awsemfexporter/pusher.go 96.49% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56652dc...6d43a96. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 1a9bf92 into open-telemetry:master Dec 7, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* Merge sdk/export/trace into sdk/trace

* Update package move

* Add changes to changelog

* Add PR number to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants