Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra exporter implementation #18416

Closed

Conversation

emreyalvac
Copy link
Member

@emreyalvac emreyalvac commented Feb 7, 2023

Description:
Cassandra Exporter for traces and logs

Link to tracking Issue: #17910

atoulme and others added 30 commits January 12, 2023 19:18
Handle the shutdown of the jmx receiver properly, providing a valid config so it can be created
…7536)

Move validation of configuration to Validate, and remove from component creation.
Fix "add codeowners to PR" workflow

GitHub has started to prepend usernames with "app/", causing the
workflow to re-request reviews from users. Removing the "app/"
prefix fixes the issue.

Co-authored-by: Evan Bradley <evan-bradley@users.noreply.github.com>
…7568)

Don't echo command to set tags on an issue

Co-authored-by: Evan Bradley <evan-bradley@users.noreply.github.com>
See issue open-telemetry#17574

Signed-off-by: Alex Boten <aboten@lightstep.com>
This reverts the main code of 7711ef4 to unblock windows tests. Will need more investigation to get the right fix in. See open-telemetry#17576

pinging @MovieStoreGuy as the original author of the change.

Signed-off-by: Alex Boten <aboten@lightstep.com>
…mutated (open-telemetry#17553)

Make all exported Compare functions not mutated for Logs, Metrics, and Traces.
All the data from the source are copied before any mutation is done on the copied data.
…kopping/go-kit-log replace directives (open-telemetry#17577)

* [chore] remove github.com/cyriltovena/cloudflare-go replace directive

* [chore] remove github.com/dannykopping/go-kit-log replace directive
…y#17582)

Remove usage of Map.Sort and use comparetest module instead in the following receivers tests:

- awsxray
- azureeventhub
- dockerstats
- fluentforward
- receivercreator
- splunkhec
…ry#17783)

Bump github.com/SAP/go-hdb from 0.111.7 to 0.111.8 in /receiver/saphanareceiver
Bump github.com/aerospike/aerospike-client-go/v6 from 6.7.0 to 6.8.0 in /receiver/aerospikereceiver
Bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.11.1 to 1.11.2 in /cmd/telemetrygen
Bump go.uber.org/zap from 1.23.0 to 1.24.0 in /cmd/telemetrygen
Bump golang.org/x/time from 0.2.0 to 0.3.0 in /cmd/telemetrygen

Co-authored-by: codeboten <codeboten@users.noreply.github.com>
Co-authored-by: Alex Boten <aboten@lightstep.com>
…ry#17812)

dependabot updates Mon Jan 16 20:37:26 UTC 2023
Bump github.com/aerospike/aerospike-client-go/v6 from 6.7.0 to 6.8.0 in /receiver/aerospikereceiver
Bump github.com/aws/aws-sdk-go from 1.44.176 to 1.44.180 in /receiver/awscontainerinsightreceiver
Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.576 to 1.0.580 in /exporter/tencentcloudlogserviceexporter

Co-authored-by: codeboten <codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
…ry#17829)

dependabot updates Mon Jan 16 22:37:50 UTC 2023
Bump github.com/DataDog/datadog-api-client-go/v2 from 2.6.1 to 2.7.0 in /exporter/datadogexporter
Bump github.com/Shopify/sarama from 1.37.2 to 1.38.0 in /exporter/kafkaexporter
Bump github.com/Shopify/sarama from 1.37.2 to 1.38.0 in /receiver/kafkareceiver
Bump github.com/aws/aws-sdk-go from 1.44.176 to 1.44.180 in /exporter/kafkaexporter
Bump github.com/google/cadvisor from 0.47.0 to 0.47.1 in /receiver/awscontainerinsightreceiver
Bump github.com/sijms/go-ora/v2 from 2.5.21 to 2.5.23 in /receiver/sqlqueryreceiver
Bump google.golang.org/api from 0.106.0 to 0.107.0 in /exporter/googlecloudpubsubexporter
Bump google.golang.org/api from 0.106.0 to 0.107.0 in /receiver/googlecloudpubsubreceiver

Co-authored-by: codeboten <codeboten@users.noreply.github.com>
)

There are still a few CI actions triggered by PRs created by dependabot. Since those PRs will never be merged, there's no point in running any actions for them.

Signed-off-by: Alex Boten <aboten@lightstep.com>
open-telemetry#17827)

[coreinternal/pdatautil] Reduce number of allocations in hash functions
The filename for ppc64le was incorrect, and the check for the msi should have been disabled at the same time as the msi job was disabled. I've also updated the script to return an error, to prevent it from failing silently for months.

Signed-off-by: Alex Boten <aboten@lightstep.com>
…telemetry#17417)

* [pkg/translator/prw] Export _created times series if possible.

Relevant to Summaries, Histograms and Monotonic Sum metrics.
See open-telemetry#17412

* Make export of _created configurable.

* fixup! Make export of _created configurable.
…insert, select, update (open-telemetry#17589)

feat(mysqlreceiver): add mysql.commands metric with support for delete, insert, select, update

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
…open-telemetry#17832)

[processor/cumulativetodelta] Use map hash in metric identity

Use the hash of attributes map for building metric identity instead of writing all key/value pairs. It reduces the size of the identity and removes the usage of Map.Sort that will be removed soon.
…6855)

Description: Added QueueStettings validation into Config Validate method
Link to tracking Issue: open-telemetry#7841
…try#16079)

This pr adds openshift support to the resourcedetectionprocessor.
Closes open-telemetry#15694
@emreyalvac
Copy link
Member Author

emreyalvac commented Feb 8, 2023

I'm working on trace and logs unit tests.

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, please see my comments to get it over the line

.chloggen/cassandra-exporter-implementation.yaml Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
exporter/cassandraexporter/README.md Outdated Show resolved Hide resolved
exporter/cassandraexporter/README.md Show resolved Hide resolved
exporter/cassandraexporter/config.go Show resolved Hide resolved
exporter/cassandraexporter/exporter_traces.go Outdated Show resolved Hide resolved
exporter/cassandraexporter/factory.go Show resolved Hide resolved
exporter/cassandraexporter/factory.go Outdated Show resolved Hide resolved
exporter/cassandraexporter/factory_test.go Show resolved Hide resolved
exporter/cassandraexporter/helper.go Show resolved Hide resolved
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 12, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@emreyalvac
Copy link
Member Author

Branch is broken. I will fix it @atoulme

@emreyalvac emreyalvac deleted the cassandra-exporter-implementation branch February 12, 2023 11:39
@emreyalvac
Copy link
Member Author

@atoulme sorry for branch issue. I will continue from this PR #18515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol
Projects
None yet
Development

Successfully merging this pull request may close these issues.