-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cassandra exporter implementation #18416
Closed
emreyalvac
wants to merge
9,438
commits into
open-telemetry:main
from
emreyalvac:cassandra-exporter-implementation
Closed
Cassandra exporter implementation #18416
emreyalvac
wants to merge
9,438
commits into
open-telemetry:main
from
emreyalvac:cassandra-exporter-implementation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the shutdown of the jmx receiver properly, providing a valid config so it can be created
…7536) Move validation of configuration to Validate, and remove from component creation.
Fix "add codeowners to PR" workflow GitHub has started to prepend usernames with "app/", causing the workflow to re-request reviews from users. Removing the "app/" prefix fixes the issue. Co-authored-by: Evan Bradley <evan-bradley@users.noreply.github.com>
…7568) Don't echo command to set tags on an issue Co-authored-by: Evan Bradley <evan-bradley@users.noreply.github.com>
See issue open-telemetry#17574 Signed-off-by: Alex Boten <aboten@lightstep.com>
…17486) Implement factory.go and scraper.go.
This reverts the main code of 7711ef4 to unblock windows tests. Will need more investigation to get the right fix in. See open-telemetry#17576 pinging @MovieStoreGuy as the original author of the change. Signed-off-by: Alex Boten <aboten@lightstep.com>
…mutated (open-telemetry#17553) Make all exported Compare functions not mutated for Logs, Metrics, and Traces. All the data from the source are copied before any mutation is done on the copied data.
…kopping/go-kit-log replace directives (open-telemetry#17577) * [chore] remove github.com/cyriltovena/cloudflare-go replace directive * [chore] remove github.com/dannykopping/go-kit-log replace directive
…y#17582) Remove usage of Map.Sort and use comparetest module instead in the following receivers tests: - awsxray - azureeventhub - dockerstats - fluentforward - receivercreator - splunkhec
…ry#17783) Bump github.com/SAP/go-hdb from 0.111.7 to 0.111.8 in /receiver/saphanareceiver Bump github.com/aerospike/aerospike-client-go/v6 from 6.7.0 to 6.8.0 in /receiver/aerospikereceiver Bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.11.1 to 1.11.2 in /cmd/telemetrygen Bump go.uber.org/zap from 1.23.0 to 1.24.0 in /cmd/telemetrygen Bump golang.org/x/time from 0.2.0 to 0.3.0 in /cmd/telemetrygen Co-authored-by: codeboten <codeboten@users.noreply.github.com> Co-authored-by: Alex Boten <aboten@lightstep.com>
…ry#17812) dependabot updates Mon Jan 16 20:37:26 UTC 2023 Bump github.com/aerospike/aerospike-client-go/v6 from 6.7.0 to 6.8.0 in /receiver/aerospikereceiver Bump github.com/aws/aws-sdk-go from 1.44.176 to 1.44.180 in /receiver/awscontainerinsightreceiver Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.576 to 1.0.580 in /exporter/tencentcloudlogserviceexporter Co-authored-by: codeboten <codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
…ry#17829) dependabot updates Mon Jan 16 22:37:50 UTC 2023 Bump github.com/DataDog/datadog-api-client-go/v2 from 2.6.1 to 2.7.0 in /exporter/datadogexporter Bump github.com/Shopify/sarama from 1.37.2 to 1.38.0 in /exporter/kafkaexporter Bump github.com/Shopify/sarama from 1.37.2 to 1.38.0 in /receiver/kafkareceiver Bump github.com/aws/aws-sdk-go from 1.44.176 to 1.44.180 in /exporter/kafkaexporter Bump github.com/google/cadvisor from 0.47.0 to 0.47.1 in /receiver/awscontainerinsightreceiver Bump github.com/sijms/go-ora/v2 from 2.5.21 to 2.5.23 in /receiver/sqlqueryreceiver Bump google.golang.org/api from 0.106.0 to 0.107.0 in /exporter/googlecloudpubsubexporter Bump google.golang.org/api from 0.106.0 to 0.107.0 in /receiver/googlecloudpubsubreceiver Co-authored-by: codeboten <codeboten@users.noreply.github.com>
open-telemetry#17827) [coreinternal/pdatautil] Reduce number of allocations in hash functions
The filename for ppc64le was incorrect, and the check for the msi should have been disabled at the same time as the msi job was disabled. I've also updated the script to return an error, to prevent it from failing silently for months. Signed-off-by: Alex Boten <aboten@lightstep.com>
* Revert "[chore] partial revert of 7711ef4 (open-telemetry#17578)"
…telemetry#17417) * [pkg/translator/prw] Export _created times series if possible. Relevant to Summaries, Histograms and Monotonic Sum metrics. See open-telemetry#17412 * Make export of _created configurable. * fixup! Make export of _created configurable.
…insert, select, update (open-telemetry#17589) feat(mysqlreceiver): add mysql.commands metric with support for delete, insert, select, update Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
…open-telemetry#17832) [processor/cumulativetodelta] Use map hash in metric identity Use the hash of attributes map for building metric identity instead of writing all key/value pairs. It reduces the size of the identity and removes the usage of Map.Sort that will be removed soon.
…6855) Description: Added QueueStettings validation into Config Validate method Link to tracking Issue: open-telemetry#7841
…try#16079) This pr adds openshift support to the resourcedetectionprocessor. Closes open-telemetry#15694
I'm working on trace and logs unit tests. |
atoulme
reviewed
Feb 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, please see my comments to get it over the line
|
…m/emreyalvac/opentelemetry-collector-contrib into cassandra-exporter-implementation
…m/emreyalvac/opentelemetry-collector-contrib into cassandra-exporter-implementation
emreyalvac
force-pushed
the
cassandra-exporter-implementation
branch
from
February 12, 2023 11:35
de69701
to
4bf734f
Compare
emreyalvac
requested review from
MovieStoreGuy,
jpkrohling,
kovrus,
Aneurysm9,
dashpole,
djaglowski and
TylerHelmuth
as code owners
February 12, 2023 11:35
emreyalvac
requested review from
fatsheep9146,
bogdandrutu,
evan-bradley,
jsuereth,
punya,
arminru and
codeboten
as code owners
February 12, 2023 11:35
Branch is broken. I will fix it @atoulme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cassandra Exporter for traces and logs
Link to tracking Issue: #17910