-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lokiexporter] Implementation ( PR 2/3 ) #1952
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1952 +/- ##
==========================================
+ Coverage 89.15% 90.18% +1.03%
==========================================
Files 393 396 +3
Lines 19329 19493 +164
==========================================
+ Hits 17233 17580 +347
+ Misses 1641 1448 -193
- Partials 455 465 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
I think something might have gone off with auto-assigning the reviewers for this PR. Also, the community asks for this exporter. Perhaps it should be reopened @bogdandrutu @tigrannajaryan ? |
@pmm-sumo - Yeah, I plan on re-opening this PR very soon. I ended up having to refocus on other tasks the past two weeks, but will come back to this either this coming weekend or next week. |
Feel free to reopen. Not sure why it was not assigned to anyone. Was it a draft PR maybe? |
@tigrannajaryan - Yes, this was a draft PR that was still a WIP. |
@pmm-sumo - I also just responded in the Gitter channel letting Ferenc know I'll be finishing it in the near future. Thank you so much for bringing this to my attention! |
@tigrannajaryan - I'm having trouble re-opening this PR. Any chance you are able to re-open it with your permissions? |
@gramidt I can't either (not sure why). Please create a new PR. |
Thank you for trying, @tigrannajaryan! I will create a new PR. |
Bumps [actions/cache](https://github.com/actions/cache) from 2.1.5 to 2.1.6. - [Release notes](https://github.com/actions/cache/releases) - [Commits](actions/cache@v2.1.5...v2.1.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description:
The implementation of the Loki exporter.
Link to tracking Issue:
#1894
Testing:
Unit Tests
Documentation:
Godoc and README