Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/influxdb] add histogram min/max to exporter #19635

Merged

Conversation

jacobmarble
Copy link
Contributor

@jacobmarble jacobmarble commented Mar 13, 2023

Description:
Bump InfluxDB dependency to v0.3.4.
Adds histogram min/max to InfluxDB exporter.

Link to tracking Issue:
16714
Closes #16714

Testing:
Unit tests in upstream change:
influxdata/influxdb-observability#186

Documentation:
Updated example line protocol output in README.

@runforesight
Copy link

runforesight bot commented Mar 13, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(6 seconds) has decreased 41 minutes 40 seconds compared to main branch avg(41 minutes 46 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 6 seconds (41 minutes 40 seconds less than main branch avg.) and finished at 14th Mar, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 58 seconds (1 minute 9 seconds less than main branch avg.) and finished at 14th Mar, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 40 seconds and finished at 14th Mar, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 2 minutes 17 seconds and finished at 14th Mar, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

 build-and-test workflow has finished in 6 minutes 32 seconds (58 minutes 2 seconds less than main branch avg.) and finished at 14th Mar, 2023.


Job Failed Steps Tests
unittest-matrix (1.19, connector) N/A  ✅ 113  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, connector) N/A  ✅ 113  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics N/A  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) N/A  ✅ 583  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces N/A  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, internal) N/A  ✅ 583  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, extension) N/A  ✅ 543  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, processor) N/A  ✅ 1545  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) N/A  ✅ 543  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) N/A  ✅ 1545  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) N/A  ✅ 2610  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, receiver-0) N/A  ✅ 2610  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, exporter) N/A  ✅ 2491  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, receiver-1) N/A  ✅ 1940  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) N/A  ✅ 2491  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) N/A  ✅ 1940  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, other) N/A  ✅ 4728  ❌ 0  ⏭ 0    🔗 See Details
integration-tests N/A  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) N/A  ✅ 4728  ❌ 0  ⏭ 0    🔗 See Details

✅  prometheus-compliance-tests workflow has finished in 11 minutes 6 seconds (⚠️ 3 minutes 35 seconds more than main branch avg.) and finished at 14th Mar, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  e2e-tests workflow has finished in 15 minutes 47 seconds and finished at 14th Mar, 2023.


Job Failed Steps Tests
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details

✅  load-tests workflow has finished in 19 minutes 59 seconds (⚠️ 6 minutes 44 seconds more than main branch avg.) and finished at 14th Mar, 2023.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 18  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax
Copy link
Member

@jacobmarble, please rebase

@jacobmarble jacobmarble force-pushed the influxdbexporter-histogram-minmax branch from 3ef6758 to e4577c8 Compare March 14, 2023 00:13
@dmitryax dmitryax merged commit fa5c632 into open-telemetry:main Mar 14, 2023
@jacobmarble jacobmarble deleted the influxdbexporter-histogram-minmax branch March 14, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Histogram Maximum and Minimum values lost from receiving to exporting.
4 participants