Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Make prometheus tests pass with the new library #21035

Merged
merged 1 commit into from
Apr 17, 2023
Merged

[chore] Make prometheus tests pass with the new library #21035

merged 1 commit into from
Apr 17, 2023

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Apr 17, 2023 •
edited

After prometheus/client_golang#1151 the tests are failing with:

--- FAIL: TestAccumulateSummary (0.00s)
    --- FAIL: TestAccumulateSummary/Summary_with_single_point/WithTimestamp (0.00s)
        collector_test.go:663: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/prometheusexporter/collector_test.go:663
            	Error:      	"Desc{fqName: \"test_metric\", help: \"test description\", constLabels: {}, variableLabels: [{label_1 <nil>} {label_2 <nil>}]}" does not contain "variableLabels: [label_1 label_2]"
            	Test:       	TestAccumulateSummary/Summary_with_single_point/WithTimestamp
    --- FAIL: TestAccumulateSummary/Summary_with_single_point (0.00s)
        collector_test.go:663: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/prometheusexporter/collector_test.go:663
            	Error:      	"Desc{fqName: \"test_metric\", help: \"test description\", constLabels: {}, variableLabels: [{label_1 <nil>} {label_2 <nil>}]}" does not contain "variableLabels: [label_1 label_2]"
            	Test:       	TestAccumulateSummary/Summary_with_single_point

@dmitryax dmitryax requested review from a team and Aneurysm9 as code owners April 17, 2023 22:35
@dmitryax dmitryax merged commit 1edb940 into open-telemetry:dependabot-prs/2023-04-17T210255 Apr 17, 2023
@github-actions github-actions bot added this to the next release milestone Apr 17, 2023
dmitryax added a commit that referenced this pull request Apr 17, 2023
@opentelemetrybot @dmitryax
[chore] dependabot updates Mon Apr 17 21:16:01 UTC 2023 (#21033)
a3c554a 
* dependabot updates Mon Apr 17 21:15:58 UTC 2023
Bump github.com/ClickHouse/clickhouse-go/v2 from 2.8.3 to 2.9.0 in /exporter/clickhouseexporter
Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp from 1.13.0 to 1.13.1 in /exporter/datadogexporter
Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp from 1.13.0 to 1.13.1 in /processor/resourcedetectionprocessor
Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector from 0.37.0 to 0.37.1 in /exporter/googlecloudexporter
Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector from 0.37.0 to 0.37.1 in /exporter/googlemanagedprometheusexporter
Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector/googlemanagedprometheus from 0.37.0 to 0.37.1 in /exporter/googlemanagedprometheusexporter
Bump github.com/SAP/go-hdb from 1.2.0 to 1.2.1 in /receiver/saphanareceiver
Bump github.com/SAP/go-hdb from 1.2.0 to 1.2.1 in /receiver/sqlqueryreceiver
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /exporter/awscloudwatchlogsexporter
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /exporter/awsemfexporter
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /exporter/awsxrayexporter
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /exporter/datadogexporter
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /exporter/kafkaexporter
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /extension/observer/ecsobserver
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /internal/aws/awsutil
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /internal/aws/cwlogs
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /internal/aws/k8s
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /internal/aws/proxy
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /internal/aws/xray
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /internal/aws/xray/testdata/sampleapp
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /internal/metadataproviders
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /processor/resourcedetectionprocessor
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /receiver/awscontainerinsightreceiver
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /receiver/awsxrayreceiver
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/awscloudwatchlogsexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/awskinesisexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/clickhouseexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/datadogexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/elasticsearchexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/f5cloudexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/googlecloudexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/googlemanagedprometheusexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/influxdbexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/jaegerexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/kafkaexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/lokiexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/mezmoexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/prometheusremotewriteexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/pulsarexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/sapmexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/signalfxexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/skywalkingexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/splunkhecexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/tanzuobservabilityexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/zipkinexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /receiver/mongodbatlasreceiver
Bump github.com/klauspost/compress from 1.16.4 to 1.16.5 in /exporter/fileexporter
Bump github.com/lib/pq from 1.10.7 to 1.10.8 in /receiver/postgresqlreceiver
Bump github.com/lib/pq from 1.10.7 to 1.10.8 in /receiver/sqlqueryreceiver
Bump github.com/prometheus/client_golang from 1.14.0 to 1.15.0 in /exporter/prometheusexporter
Bump github.com/prometheus/client_golang from 1.14.0 to 1.15.0 in /receiver/simpleprometheusreceiver/examples/federation/prom-counter
Bump github.com/rs/cors from 1.8.3 to 1.9.0 in /receiver/opencensusreceiver
Bump github.com/sijms/go-ora/v2 from 2.6.15 to 2.6.17 in /receiver/sqlqueryreceiver
Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.634 to 1.0.639 in /exporter/tencentcloudlogserviceexporter
Bump go.mongodb.org/atlas from 0.24.0 to 0.25.0 in /receiver/mongodbatlasreceiver
Bump go.opentelemetry.io/build-tools/checkdoc from 0.6.0 to 0.7.0 in /internal/tools
Bump go.opentelemetry.io/build-tools/chloggen from 0.6.0 to 0.7.0 in /internal/tools
Bump go.opentelemetry.io/build-tools/crosslink from 0.6.0 to 0.7.0 in /internal/tools
Bump go.opentelemetry.io/build-tools/issuegenerator from 0.6.0 to 0.7.0 in /internal/tools
Bump go.opentelemetry.io/build-tools/multimod from 0.6.0 to 0.7.0 in /internal/tools
Bump google.golang.org/api from 0.117.0 to 0.118.0 in /exporter/f5cloudexporter
Bump google.golang.org/api from 0.117.0 to 0.118.0 in /exporter/googlecloudpubsubexporter
Bump google.golang.org/api from 0.117.0 to 0.118.0 in /receiver/googlecloudpubsubreceiver
Bump google.golang.org/api from 0.117.0 to 0.118.0 in /receiver/googlecloudspannerreceiver

* [chore] Make prometheus tests pass with the new library (#21035)

---------

Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
@dmitryax dmitryax deleted the dependabot-prs/2023-04-17T210255 branch April 17, 2023 23:23
vincentfree pushed a commit to ing-bank/opentelemetry-collector-contrib that referenced this pull request Apr 18, 2023
@opentelemetrybot @dmitryax @vincentfree
[chore] dependabot updates Mon Apr 17 21:16:01 UTC 2023 (open-telemet…
04bd9b8 
…ry#21033)

* dependabot updates Mon Apr 17 21:15:58 UTC 2023
Bump github.com/ClickHouse/clickhouse-go/v2 from 2.8.3 to 2.9.0 in /exporter/clickhouseexporter
Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp from 1.13.0 to 1.13.1 in /exporter/datadogexporter
Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp from 1.13.0 to 1.13.1 in /processor/resourcedetectionprocessor
Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector from 0.37.0 to 0.37.1 in /exporter/googlecloudexporter
Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector from 0.37.0 to 0.37.1 in /exporter/googlemanagedprometheusexporter
Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector/googlemanagedprometheus from 0.37.0 to 0.37.1 in /exporter/googlemanagedprometheusexporter
Bump github.com/SAP/go-hdb from 1.2.0 to 1.2.1 in /receiver/saphanareceiver
Bump github.com/SAP/go-hdb from 1.2.0 to 1.2.1 in /receiver/sqlqueryreceiver
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /exporter/awscloudwatchlogsexporter
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /exporter/awsemfexporter
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /exporter/awsxrayexporter
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /exporter/datadogexporter
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /exporter/kafkaexporter
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /extension/observer/ecsobserver
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /internal/aws/awsutil
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /internal/aws/cwlogs
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /internal/aws/k8s
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /internal/aws/proxy
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /internal/aws/xray
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /internal/aws/xray/testdata/sampleapp
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /internal/metadataproviders
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /processor/resourcedetectionprocessor
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /receiver/awscontainerinsightreceiver
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 in /receiver/awsxrayreceiver
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/awscloudwatchlogsexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/awskinesisexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/clickhouseexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/datadogexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/elasticsearchexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/f5cloudexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/googlecloudexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/googlemanagedprometheusexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/influxdbexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/jaegerexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/kafkaexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/lokiexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/mezmoexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/prometheusremotewriteexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/pulsarexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/sapmexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/signalfxexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/skywalkingexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/splunkhecexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/tanzuobservabilityexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /exporter/zipkinexporter
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1 in /receiver/mongodbatlasreceiver
Bump github.com/klauspost/compress from 1.16.4 to 1.16.5 in /exporter/fileexporter
Bump github.com/lib/pq from 1.10.7 to 1.10.8 in /receiver/postgresqlreceiver
Bump github.com/lib/pq from 1.10.7 to 1.10.8 in /receiver/sqlqueryreceiver
Bump github.com/prometheus/client_golang from 1.14.0 to 1.15.0 in /exporter/prometheusexporter
Bump github.com/prometheus/client_golang from 1.14.0 to 1.15.0 in /receiver/simpleprometheusreceiver/examples/federation/prom-counter
Bump github.com/rs/cors from 1.8.3 to 1.9.0 in /receiver/opencensusreceiver
Bump github.com/sijms/go-ora/v2 from 2.6.15 to 2.6.17 in /receiver/sqlqueryreceiver
Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.634 to 1.0.639 in /exporter/tencentcloudlogserviceexporter
Bump go.mongodb.org/atlas from 0.24.0 to 0.25.0 in /receiver/mongodbatlasreceiver
Bump go.opentelemetry.io/build-tools/checkdoc from 0.6.0 to 0.7.0 in /internal/tools
Bump go.opentelemetry.io/build-tools/chloggen from 0.6.0 to 0.7.0 in /internal/tools
Bump go.opentelemetry.io/build-tools/crosslink from 0.6.0 to 0.7.0 in /internal/tools
Bump go.opentelemetry.io/build-tools/issuegenerator from 0.6.0 to 0.7.0 in /internal/tools
Bump go.opentelemetry.io/build-tools/multimod from 0.6.0 to 0.7.0 in /internal/tools
Bump google.golang.org/api from 0.117.0 to 0.118.0 in /exporter/f5cloudexporter
Bump google.golang.org/api from 0.117.0 to 0.118.0 in /exporter/googlecloudpubsubexporter
Bump google.golang.org/api from 0.117.0 to 0.118.0 in /receiver/googlecloudpubsubreceiver
Bump google.golang.org/api from 0.117.0 to 0.118.0 in /receiver/googlecloudspannerreceiver

* [chore] Make prometheus tests pass with the new library (open-telemetry#21035)

---------

Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees

@jpkrohling jpkrohling

Labels
exporter/prometheus
Projects
None yet
Milestone
v0.76.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmitryax @atoulme @jpkrohling