[pkg/ottl] Add new IsMap and IsString functions
#22750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-bradley
reviewed
Jun 6, 2023
There was a problem hiding this comment.
Overall I think this looks good, but as we discussed offline I think it would make sense to use the typed Getters to do the type checking in these functions so we have a single source of truth for type checks. We could have these functions take typed Getter parameters, then check whether the typed Getter returns an error. To distinguish type errors from other errors, typed Getters would return a TypeError or similar error type that indicates an error is from a type mismatch.
TylerHelmuth
force-pushed
the
ottl-check-type
branch
from
6e220ae to
29299b6
Compare
evan-bradley
reviewed
Jun 8, 2023
This reverts commit 386d53540e5d1bb1cc8d0e30cf1db47309460d57.
TylerHelmuth
force-pushed
the
ottl-check-type
branch
from
386d535 to
28205a8
Compare
evan-bradley
reviewed
Jun 9, 2023
evan-bradley
reviewed
Jun 9, 2023
evan-bradley
approved these changes
Jun 9, 2023
Caleb-Hurshman
pushed a commit
to observIQ/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2023
…2750) * Add new functions * Add docs * changelog * fix lint * Switch to typed getters using typed errors * Use errors.As * Revert "Use errors.As" This reverts commit 386d53540e5d1bb1cc8d0e30cf1db47309460d57. * Ensure wrapped TypeErrors are returned * Add type check to tests * Added more tests * Use TypeError in tests to ensure the error is wrapped * Check that false is returned with error * Fix lint * Wrap errors in TypeLike getters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds new functions to facilitate type checking. Most useful when checking the type of a body to determine if it needs to be parsed or not.
Link to tracking Issue:
Closes #22161
Testing:
Added tests
Documentation:
Updated func readme