Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f5cloudexporter: Implemented User-Agent header with version #2292

Merged
merged 2 commits into from
Feb 9, 2021
Merged

f5cloudexporter: Implemented User-Agent header with version #2292

merged 2 commits into from
Feb 9, 2021

Conversation

gramidt
Copy link
Member

@gramidt gramidt commented Feb 7, 2021

Signed-off-by: Granville Schmidt 1246157+gramidt@users.noreply.github.com

Description:
Adds 'User-Agent' header with version to requests

Link to tracking Issue:
#2291

Testing:
Unit tests

Documentation:
N/A

@gramidt gramidt requested a review from a team February 7, 2021 22:15
@gramidt gramidt changed the title implemented User-Agent header with version f5cloudexported] Implemented User-Agent header with version Feb 7, 2021
@gramidt gramidt changed the title f5cloudexported] Implemented User-Agent header with version f5cloudexporter: Implemented User-Agent header with version Feb 7, 2021
exporter/f5cloudexporter/factory.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #2292 (d8bc686) into main (f296b17) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2292      +/-   ##
==========================================
+ Coverage   90.73%   90.74%   +0.01%     
==========================================
  Files         400      400              
  Lines       19891    19896       +5     
==========================================
+ Hits        18048    18055       +7     
+ Misses       1382     1381       -1     
+ Partials      461      460       -1     
Flag Coverage Δ
integration 69.26% <ø> (ø)
unit 89.56% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/f5cloudexporter/factory.go 91.66% <100.00%> (+1.34%) ⬆️
receiver/k8sclusterreceiver/watcher.go 97.64% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f296b17...d8bc686. Read the comment docs.

Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
@bogdandrutu bogdandrutu merged commit e23a54b into open-telemetry:main Feb 9, 2021
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
* implemented User-Agent header with version

Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>

* updated function name per recommendation

Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants