Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][receiver/mysql] Migrate away from timing based setup in integration test #23003

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Jun 1, 2023

Resolves #18286

This moves away from a custom docker file w/ a timing based setup script. Instead, we rely on testcontainers to run a script once the container is ready.

Several minor accompanying changes were made here as well:

  • Do not grant select permissions to the innodb_metrics table, as it turns out that each user automatically has appropriate row-based permissions to this table. Also remove documentation citing this as a prereq.
  • Grant permissions to performance_schema tables, because we were logging errors from failed queries added in [receiver/mysql]: add scraping io_waits metrics #14328.
  • Do not consider a lack of replication metrics as an error, since these are expected to be absent unless replication is configured.
  • Add a debugging feature to scraperinttest, which allows us to force a failure if any errors are logged by a scraper. This should only be used for developing tests due to a lack or correlation with individual scrapes.

@djaglowski djaglowski force-pushed the mysql-int-test-fix branch from 72c6068 to 4c548f5 Compare June 1, 2023 18:25
@djaglowski djaglowski marked this pull request as ready for review June 1, 2023 19:36
@djaglowski djaglowski requested review from a team, evan-bradley and codeboten June 1, 2023 19:36
@djaglowski
Copy link
Member Author

@open-telemetry/collector-contrib-approvers, PTAL

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one question.

@djaglowski djaglowski merged commit 6b85542 into open-telemetry:main Jun 5, 2023
@djaglowski djaglowski deleted the mysql-int-test-fix branch June 5, 2023 14:17
@github-actions github-actions bot added this to the next release milestone Jun 5, 2023
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
…ration test (open-telemetry#23003)

* [chore][receiver/mysql] Migrate away from timing based setup in integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/mysql] Flaky integration test
3 participants