Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datasetexporter]: Update CODEOWNERS add zdaratom #23149

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[exporter/datasetexporter]: Update CODEOWNERS add zdaratom #23149

merged 1 commit into from
Jul 11, 2023

Conversation

zdaratom-s1
Copy link
Contributor

@zdaratom-s1 zdaratom-s1 commented Jun 6, 2023

Description: add zdaratom as codeowner for datasetexporter
Link to tracking Issue: #20660
Testing: NA
Documentation: NA

@zdaratom-s1 zdaratom-s1 requested review from a team and fatsheep9146 June 6, 2023 09:41
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 6, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: zdaratom / name: Tomáš Žďára (b8e8217)

@fatsheep9146
Copy link
Contributor

I think the codeowner should have contributed several issues about this component, and get sponsor from existing codeowners.

@zdaratom
Do you have contributed for datasetexporter? Do you get the sponsor from existing owners?

@zdaratom-s1
Copy link
Contributor Author

zdaratom-s1 commented Jun 6, 2023

Yes I do have sponsor from @martin-majlis-s1, the reason why I created this PR was to Authorise EasyCLA - that was the suggested approach in docs - create PR in order to get authorization in EasyCLA

@atoulme
Copy link
Contributor

atoulme commented Jun 7, 2023

@zdaratom welcome to the project! You need to become a member of the OpenTelemetry organization ahead of becoming a codeowner. Please see https://github.com/open-telemetry/community/issues/new?assignees=&labels=area%2Fgithub-membership&projects=&template=membership.md&title=REQUEST%3A+New+membership+for+%3Cyour-GH-handle%3E to get started.

@zdaratom-s1
Copy link
Contributor Author

zdaratom-s1 commented Jun 7, 2023

Thanks @atoulme for tip, I have opened PR

@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 14, 2023
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, @zdaratom has membership and provided at least a PR to the repository showing intent to maintain the code.

@zdaratom-s1 zdaratom-s1 reopened this Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.36 🎉

Comparison is base (2ae4bb7) 82.81% compared to head (bc1e238) 83.17%.

❗ Current head bc1e238 differs from pull request most recent head 1abb66d. Consider uploading reports for the commit 1abb66d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23149      +/-   ##
==========================================
+ Coverage   82.81%   83.17%   +0.36%     
==========================================
  Files        1577     1552      -25     
  Lines      151647   153993    +2346     
==========================================
+ Hits       125586   128086    +2500     
+ Misses      22637    22511     -126     
+ Partials     3424     3396      -28     

see 215 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fatsheep9146 fatsheep9146 added the ready to merge Code review completed; ready to merge by maintainers label Jun 25, 2023
@codeboten
Copy link
Contributor

@zdaratom please rebase the branch to get CI to pass

@codeboten codeboten added waiting for author and removed ready to merge Code review completed; ready to merge by maintainers labels Jul 4, 2023
@zdaratom-s1 zdaratom-s1 reopened this Jul 11, 2023
@codeboten codeboten merged commit df91b0a into open-telemetry:main Jul 11, 2023
@github-actions github-actions bot added this to the next release milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/dataset Skip Changelog PRs that do not require a CHANGELOG.md entry waiting for author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants