-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/datasetexporter]: Update CODEOWNERS add zdaratom #23149
Conversation
|
I think the codeowner should have contributed several issues about this component, and get sponsor from existing codeowners. @zdaratom |
Yes I do have sponsor from @martin-majlis-s1, the reason why I created this PR was to Authorise EasyCLA - that was the suggested approach in docs - create PR in order to get authorization in EasyCLA |
@zdaratom welcome to the project! You need to become a member of the OpenTelemetry organization ahead of becoming a codeowner. Please see https://github.com/open-telemetry/community/issues/new?assignees=&labels=area%2Fgithub-membership&projects=&template=membership.md&title=REQUEST%3A+New+membership+for+%3Cyour-GH-handle%3E to get started. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, @zdaratom has membership and provided at least a PR to the repository showing intent to maintain the code.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #23149 +/- ##
==========================================
+ Coverage 82.81% 83.17% +0.36%
==========================================
Files 1577 1552 -25
Lines 151647 153993 +2346
==========================================
+ Hits 125586 128086 +2500
+ Misses 22637 22511 -126
+ Partials 3424 3396 -28 ☔ View full report in Codecov by Sentry. |
@zdaratom please rebase the branch to get CI to pass |
Description: add zdaratom as codeowner for datasetexporter
Link to tracking Issue: #20660
Testing: NA
Documentation: NA