[pkg/ottl] Add StandardFuncs and StandardConverters to ottlfuncs #23190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal/filter
pkg/ottl
processor/transform
evan-bradley
approved these changes
Jun 7, 2023
rnishtala-sumo
approved these changes
Jun 7, 2023
Caleb-Hurshman
pushed a commit
to observIQ/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2023
…n-telemetry#23190) * Add StandardFuncs and StandardConverters to ottlfuncs * changelog * add license * make goporto * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently every time a function is added to
ottlfuncsit must then be manually added to each component that uses OTTL (assuming that the component wants access to it). As OTTL's usage has grown across Contrib this has become more tedious.To ease this process for components that want all available editors/converts from
ottlfuncsI've addedStandardFuncsandStandardConvertersgroups. These methods allow components access to all the standard functions (or only the converters) inottlfuncs. Going forward, whenever a new function is added these lists can be updated and all the components that are opting in will get the components in the next release.