Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter/OpenSearch] OpenSearch exporter setup #23819
[Exporter/OpenSearch] OpenSearch exporter setup #23819
Changes from 33 commits
31742d8
cb37238
89dca47
1928c8f
4a1672b
aa474de
8758cba
e355bd2
969fc59
b4aedd5
b2ae742
3d99174
f9dd5cd
d1a6c93
29076e6
4a35bea
62dd060
e286d18
8a51d24
85d206f
fdc9b14
a078ad6
ee759b6
22fcf52
581ac14
d4db8ab
bb9972f
993ce1a
244fc29
9fce291
d57a6af
c778313
c6eaf01
50db30a
e240c46
e383557
fc8d591
9575754
4d7d124
a2ed3e8
232e82d
0f53242
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably use the
exporterhelper.RetrySettings
type to provide consistency of configuration across exporters.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values are used to create a backoff function for the OpenSearch client.
We'll check if
exporterhelper.RetrySettings
can be used here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config struct can be changed to use
exporterhelper.RetrySettings
but the implied behaviour may be different.exporterhelper.WithRetry
retries a batch of trace records, right? OpenSearch supports retrying one failed document from a bulk indexing request.Would it be more appropriate to log documents that OpenSearch failed to index and move on? Currently they are added back to the bulk indexer queue to be tried later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the
consumererror.Traces
type to return an error containing the spans that failed to export. Theexporterhelper
error handler will unwrap the error, extract the spans, and replace the request with one containing just the failed spans.