Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed Internal Datadog Module Component #24650

Merged
merged 35 commits into from
Aug 7, 2023
Merged

Proposed Internal Datadog Module Component #24650

merged 35 commits into from
Aug 7, 2023

Conversation

gord02
Copy link
Contributor

@gord02 gord02 commented Jul 27, 2023 •
edited
Loading

Component(s):
processor/datadog

The Datadog processor is a component the needs to be deprecated in favor of the Datadog connector. The migration from one component to the other will take effect after two minor releases. Therefore, during the deprecation process, code that is used by the Datadog processor and connector can be shared instead of duplicated.

Link to relevant issue

@gord02 gord02 requested a review from a team July 27, 2023 19:35
@gord02 gord02 requested review from mx-psi and dmitryax as code owners July 27, 2023 19:35
@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command processor/datadog labels Jul 27, 2023
@github-actions github-actions bot requested review from dineshg13, gbbr and pmcollins July 27, 2023 19:36
@atoulme
Copy link
Contributor

atoulme commented Jul 27, 2023

We are going to need codeowners for that new package. Please copy this file for example, and enter codeowners for this path:
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/internal/docker/metadata.yaml

Note codeowners must be members of the OpenTelemetry Github organization. More info in CONTRIBUTING.md. Thanks!

@gord02 gord02 marked this pull request as draft July 27, 2023 21:01
mx-psi
mx-psi reviewed Jul 31, 2023
View reviewed changes
cmd/otelcontribcol/components.go Outdated Show resolved Hide resolved
cmd/otelcontribcol/go.mod Outdated Show resolved Hide resolved
cmd/otelcontribcol/main.go Outdated Show resolved Hide resolved
internal/datadog/go.mod Outdated Show resolved Hide resolved
@mx-psi
Copy link
Member

mx-psi commented Jul 31, 2023

@gbbr can you review?

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 31, 2023
@gord02 gord02 changed the title Proposed Internal Datadog Module Proposed Internal Datadog Module Component Jul 31, 2023
@mx-psi
Copy link
Member

mx-psi commented Aug 3, 2023

needs a rebase

songy23
songy23 reviewed Aug 3, 2023
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependabot.yml is out of date, please run "make gendependabot" and commit the changes in this PR.

gbbr
gbbr approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

internal/datadog/agent.go Outdated Show resolved Hide resolved
gbbr
gbbr reviewed Aug 4, 2023
View reviewed changes
internal/datadog/agent_test.go Outdated Show resolved Hide resolved
@mx-psi
Copy link
Member

mx-psi commented Aug 4, 2023

Generated code is out of date, please run "make gengithub" and commit the changes in this PR.

songy23
songy23 reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you probably ran into #19410, for now please make some manual updates to .github/dependabot.yml to make CI pass

.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
songy23
songy23 reviewed Aug 4, 2023
View reviewed changes
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
@songy23
Copy link
Member

songy23 commented Aug 4, 2023

Dropdowns in issue templates are out of date, please run "make generate-gh-issue-templates" and commit the changes in this PR.

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Aug 4, 2023
@mx-psi mx-psi merged commit 99aa153 into open-telemetry:main Aug 7, 2023
@github-actions github-actions bot added this to the next release milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbr gbbr gbbr approved these changes

@songy23 songy23 songy23 approved these changes

@mx-psi mx-psi mx-psi approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@pmcollins pmcollins Awaiting requested review from pmcollins

Assignees

@jpkrohling jpkrohling

@codeboten codeboten

Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command processor/datadog ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.83.0
Development

Successfully merging this pull request may close these issues.
7 participants
@gord02 @atoulme @mx-psi @songy23 @gbbr @jpkrohling @codeboten