[receiver/kubeletstats] Add new memory utilization metrics #25894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A good comment was brought in the issue: #24905 (comment). Let's discuss that first. |
|
@dmitryax if you feel good about the |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
SGTM |
|
@dmitryax updated the names and implemented |
TylerHelmuth
changed the title
TylerHelmuth
force-pushed
the
kubeletstats-memory-utilization
branch
from
6fe5916 to
e9f8810
Compare
|
@dmitryax this is ready for a proper review. |
dmitryax
reviewed
Sep 26, 2023
|
@dmitryax ready for review |
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…metry#25894) **Description:** Adds new `k8s.pod.memory.utilization` and `container.memory.utilization` metrics that represent the ratio of memory used vs limits set. The metrics are only emitted for pods/containers that have defined resource limits. It takes advantage of the pod metadata to acquire the container limits. A pod limit is computed as the sum of all the container limits and if any container limit is zero or undefined the pod limit is also considered undefined. **Link to tracking Issue:** Related to open-telemetry#24905 **Testing:** Unit tests and local testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds new
k8s.pod.memory.utilizationandcontainer.memory.utilizationmetrics that represent the ratio of memory used vs limits set.The metrics are only emitted for pods/containers that have defined resource limits. It takes advantage of the pod metadata to acquire the container limits. A pod limit is computed as the sum of all the container limits and if any container limit is zero or undefined the pod limit is also considered undefined.
Link to tracking Issue:
Related to #24905
Testing:
Unit tests and local testing