Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kafka] Do not expose method #26379

Closed
wants to merge 2 commits into from

Conversation

vanpt1114
Copy link

Description:
Remove exposed function, only keep NewFactory

  • WithTracesUnmarshalers
  • WithMetricsUnmarshalers
  • WithLogsUnmarshalers
  • MetricViews

Link to tracking Issue:
#26304

@vanpt1114 vanpt1114 requested a review from a team September 2, 2023 17:37
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 2, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: vanpt1114 / name: Van Phan (96236ae)
  • ✅ login: codeboten / name: Alex Boten (20a262b)

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Oct 5, 2023
@crobert-1 crobert-1 reopened this Oct 5, 2023
@crobert-1
Copy link
Member

I'm actually going to close this again, I found this is a duplicate of #26644, which has more activity on it. Thanks for the contribution though @vanpt1114, sorry about the confusion here!

@crobert-1 crobert-1 closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants