Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update statsdreceiver to checkapi standards #26471

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Update statsdreceiver to checkapi standards #26471

merged 6 commits into from
Sep 6, 2023

Conversation

greatestusername
Copy link
Contributor

Description:
stops exporting New method to align with checkapi standards as related to issue #26304

Link to tracking Issue: 26304

Testing:

  • go run cmd/checkapi/main.go .
  • go test for statsdreceiver

Documentation:

@greatestusername greatestusername requested a review from a team September 5, 2023 16:47
@github-actions github-actions bot added the receiver/statsd statsd related issues label Sep 5, 2023
atoulme
atoulme approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeboten codeboten merged commit ac29d5b into open-telemetry:main Sep 6, 2023
90 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 6, 2023
@atoulme atoulme mentioned this pull request Sep 7, 2023
Closed
44 tasks
@greatestusername greatestusername deleted the checkapi-statsd-26304 branch September 14, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

@codeboten codeboten codeboten approved these changes

@atoulme atoulme atoulme approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees

@evan-bradley evan-bradley

Labels
receiver/statsd statsd related issues
Projects
None yet
Milestone
v0.85.0
Development

Successfully merging this pull request may close these issues.
5 participants
@greatestusername @atoulme @codeboten @jmacd @evan-bradley